## Issue Addressed
NA
## Proposed Changes
Implements the `PrettyReqwestError` to wrap a `reqwest::Error` and give nicer `Debug` formatting. It also wraps the `Url` component in a `SensitiveUrl` to avoid leaking sensitive info in logs.
### Before
```
Reqwest(reqwest::Error { kind: Request, url: Url { scheme: "http", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("localhost")), port: Some(9999), path: "/eth/v1/node/version", query: None, fragment: None }, source: hyper::Error(Connect, ConnectError("tcp connect error", Os { code: 61, kind: ConnectionRefused, message: "Connection refused" })) })
```
### After
```
HttpClient(url: http://localhost:9999/, kind: request, detail: error trying to connect: tcp connect error: Connection refused (os error 61))
```
## Additional Info
I've also renamed the `Reqwest` error enum variants to `HttpClient`, to give people a better chance at knowing what's going on. Reqwest is pretty odd and looks like a typo.
I've implemented it in the `eth2` and `execution_layer` crates. This should affect most logs in the VC and EE-related ones in the BN.
I think the last crate that could benefit from the is the `beacon_node/eth1` crate. I haven't updated it in this PR since its error type is not so amenable to it (everything goes into a `String`). I don't have a whole lot of time to jig around with that at the moment and I feel that this PR as it stands is a significant enough improvement to merge on its own. Leaving it as-is is fine for the time being and we can always come back for it later (or implement in-protocol deposits!).
|
||
|---|---|---|
| .. | ||
| account_utils | ||
| clap_utils | ||
| compare_fields | ||
| compare_fields_derive | ||
| deposit_contract | ||
| directory | ||
| eth2 | ||
| eth2_config | ||
| eth2_interop_keypairs | ||
| eth2_network_config | ||
| eth2_wallet_manager | ||
| filesystem | ||
| lighthouse_metrics | ||
| lighthouse_version | ||
| lockfile | ||
| logging | ||
| lru_cache | ||
| malloc_utils | ||
| monitoring_api | ||
| oneshot_broadcast | ||
| pretty_reqwest_error | ||
| sensitive_url | ||
| slot_clock | ||
| system_health | ||
| target_check | ||
| task_executor | ||
| test_random_derive | ||
| unused_port | ||
| validator_dir | ||
| warp_utils | ||
| README.md | ||
eth2
Common crates containing eth2-specific logic.