lighthouse/beacon_node/network/src
Paul Hauner 661307dce1 Separate committee subscriptions queue (#3508)
## Issue Addressed

NA

## Proposed Changes

As we've seen on Prater, there seems to be a correlation between these messages

```
WARN Not enough time for a discovery search  subnet_id: ExactSubnet { subnet_id: SubnetId(19), slot: Slot(3742336) }, service: attestation_service
```

... and nodes falling 20-30 slots behind the head for short periods. These nodes are running ~20k Prater validators.

After running some metrics, I can see that the `network_recv` channel is processing ~250k `AttestationSubscribe` messages per minute. It occurred to me that perhaps the `AttestationSubscribe` messages are "washing out" the `SendRequest` and `SendResponse` messages. In this PR I separate the `AttestationSubscribe` and `SyncCommitteeSubscribe` messages into their own queue so the `tokio::select!` in the `NetworkService` can still process the other messages in the `network_recv` channel without necessarily having to clear all the subscription messages first.

~~I've also added filter to the HTTP API to prevent duplicate subscriptions going to the network service.~~

## Additional Info

- Currently being tested on Prater
2022-08-30 05:47:31 +00:00
..
beacon_processor Refactor op pool for speed and correctness (#3312) 2022-08-29 09:10:26 +00:00
router Remove unused method in HandlerNetworkContext (#3299) 2022-07-04 02:56:14 +00:00
service Filter non global ips from discovery (#3023) 2022-03-02 03:14:27 +00:00
subnet_service Use async code when interacting with EL (#3244) 2022-07-03 05:36:50 +00:00
sync Pause sync when EE is offline (#3428) 2022-08-24 23:34:56 +00:00
error.rs Rename eth2_libp2p to lighthouse_network (#2702) 2021-10-19 00:30:39 +00:00
lib.rs Separate committee subscriptions queue (#3508) 2022-08-30 05:47:31 +00:00
metrics.rs Separate committee subscriptions queue (#3508) 2022-08-30 05:47:31 +00:00
nat.rs rust 1.53.0 updates (#2411) 2021-06-18 05:58:01 +00:00
persisted_dht.rs Rename eth2_libp2p to lighthouse_network (#2702) 2021-10-19 00:30:39 +00:00
service.rs Separate committee subscriptions queue (#3508) 2022-08-30 05:47:31 +00:00
status.rs Use async code when interacting with EL (#3244) 2022-07-03 05:36:50 +00:00