434386774e
## Issue Addressed There was a [`VecDeque` bug](https://github.com/rust-lang/rust/issues/108453) in some recent versions of the Rust standard library (1.67.0 & 1.67.1) that could cause Lighthouse to panic (reported by `@Sea Monkey` on discord). See full logs below. The issue was likely introduced in Rust 1.67.0 and [fixed](https://github.com/rust-lang/rust/pull/108475) in 1.68, and we were able to reproduce the panic ourselves using [@michaelsproul's fuzz tests](https://github.com/michaelsproul/lighthouse/blob/fuzz-lru-time-cache/beacon_node/lighthouse_network/src/peer_manager/fuzz.rs#L111) on both Rust 1.67.0 and 1.67.1. Users that uses our Docker images or binaries are unlikely affected, as our Docker images were built with `1.66`, and latest binaries were built with latest stable (`1.68.2`). It likely impacts user that builds from source using Rust versions 1.67.x. ## Proposed Changes Bump Rust version (MSRV) to latest stable `1.68.2`. ## Additional Info From `@Sea Monkey` on Lighthouse Discord: > Crash on goerli using `unstable` `dd124b2d6804d02e4e221f29387a56775acccd08` ``` thread 'tokio-runtime-worker' panicked at 'Key must exist', /mnt/goerli/goerli/lighthouse/common/lru_cache/src/time.rs:68:28 stack backtrace: Apr 15 09:37:36.993 WARN Peer sent invalid block in single block lookup, peer_id: 16Uiu2HAm6ZuyJpVpR6y51X4Enbp8EhRBqGycQsDMPX7e5XfPYznG, error: WouldRevertFinalizedSlot { block_slot: Slot(5420212), finalized_slot: Slot(5420224) }, root: 0x10f6…3165, service: sync 0: rust_begin_unwind at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/std/src/panicking.rs:575:5 1: core::panicking::panic_fmt at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/panicking.rs:64:14 2: core::panicking::panic_display at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/panicking.rs:135:5 3: core::panicking::panic_str at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/panicking.rs:119:5 4: core::option::expect_failed at /rustc/d5a82bbd26e1ad8b7401f6a718a9c57c96905483/library/core/src/option.rs:1879:5 5: lru_cache::time::LRUTimeCache<Key>::raw_remove 6: lighthouse_network::peer_manager::PeerManager<TSpec>::handle_ban_operation 7: lighthouse_network::peer_manager::PeerManager<TSpec>::handle_score_action 8: lighthouse_network::peer_manager::PeerManager<TSpec>::report_peer 9: network::service::NetworkService<T>::spawn_service::{{closure}} 10: <futures_util::future::select::Select<A,B> as core::future::future::Future>::poll 11: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll 12: <futures_util::future::future::flatten::Flatten<Fut,<Fut as core::future::future::Future>::Output> as core::future::future::Future>::poll 13: tokio::loom::std::unsafe_cell::UnsafeCell<T>::with_mut 14: tokio::runtime::task::core::Core<T,S>::poll 15: tokio::runtime::task::harness::Harness<T,S>::poll 16: tokio::runtime::scheduler::multi_thread::worker::Context::run_task 17: tokio::runtime::scheduler::multi_thread::worker::Context::run 18: tokio::macros::scoped_tls::ScopedKey<T>::set 19: tokio::runtime::scheduler::multi_thread::worker::run 20: tokio::loom::std::unsafe_cell::UnsafeCell<T>::with_mut 21: tokio::runtime::task::core::Core<T,S>::poll 22: tokio::runtime::task::harness::Harness<T,S>::poll 23: tokio::runtime::blocking::pool::Inner::run note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace. Apr 15 09:37:37.069 INFO Saved DHT state service: network Apr 15 09:37:37.070 INFO Network service shutdown service: network Apr 15 09:37:37.132 CRIT Task panic. This is a bug! advice: Please check above for a backtrace and notify the developers, message: <none>, task_name: network Apr 15 09:37:37.132 INFO Internal shutdown received reason: Panic (fatal error) Apr 15 09:37:37.133 INFO Shutting down.. reason: Failure("Panic (fatal error)") Apr 15 09:37:37.135 WARN Unable to free worker error: channel closed, msg: did not free worker, shutdown may be underway Apr 15 09:37:39.350 INFO Saved beacon chain to disk service: beacon Panic (fatal error) ```
402 lines
13 KiB
YAML
402 lines
13 KiB
YAML
name: test-suite
|
|
|
|
on:
|
|
push:
|
|
branches:
|
|
- stable
|
|
- staging
|
|
- trying
|
|
- 'pr/*'
|
|
pull_request:
|
|
env:
|
|
# Deny warnings in CI
|
|
# Disable debug info (see https://github.com/sigp/lighthouse/issues/4005)
|
|
RUSTFLAGS: "-D warnings -C debuginfo=0"
|
|
# The Nightly version used for cargo-udeps, might need updating from time to time.
|
|
PINNED_NIGHTLY: nightly-2023-04-16
|
|
# Prevent Github API rate limiting.
|
|
LIGHTHOUSE_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
jobs:
|
|
target-branch-check:
|
|
name: target-branch-check
|
|
runs-on: ubuntu-latest
|
|
if: github.event_name == 'pull_request'
|
|
steps:
|
|
- name: Check that the pull request is not targeting the stable branch
|
|
run: test ${{ github.base_ref }} != "stable"
|
|
extract-msrv:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Extract Minimum Supported Rust Version (MSRV)
|
|
run: |
|
|
metadata=$(cargo metadata --no-deps --format-version 1)
|
|
msrv=$(echo $metadata | jq -r '.packages | map(select(.name == "lighthouse")) | .[0].rust_version')
|
|
echo "MSRV=$msrv" >> $GITHUB_OUTPUT
|
|
id: extract_msrv
|
|
outputs:
|
|
MSRV: ${{ steps.extract_msrv.outputs.MSRV }}
|
|
cargo-fmt:
|
|
name: cargo-fmt
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Check formatting with cargo fmt
|
|
run: make cargo-fmt
|
|
release-tests-ubuntu:
|
|
name: release-tests-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install Protoc
|
|
uses: arduino/setup-protoc@e52d9eb8f7b63115df1ac544a1376fdbf5a39612
|
|
with:
|
|
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: Install ganache
|
|
run: sudo npm install -g ganache
|
|
- name: Run tests in release
|
|
run: make test-release
|
|
release-tests-windows:
|
|
name: release-tests-windows
|
|
runs-on: windows-2019
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Use Node.js
|
|
uses: actions/setup-node@v2
|
|
with:
|
|
node-version: '14'
|
|
- name: Install windows build tools
|
|
run: |
|
|
choco install python protoc visualstudio2019-workload-vctools -y
|
|
npm config set msvs_version 2019
|
|
- name: Install ganache
|
|
run: npm install -g ganache --loglevel verbose
|
|
- name: Install make
|
|
run: choco install -y make
|
|
- uses: KyleMayes/install-llvm-action@v1
|
|
with:
|
|
version: "13.0"
|
|
directory: ${{ runner.temp }}/llvm
|
|
- name: Set LIBCLANG_PATH
|
|
run: echo "LIBCLANG_PATH=$((gcm clang).source -replace "clang.exe")" >> $env:GITHUB_ENV
|
|
- name: Run tests in release
|
|
run: make test-release
|
|
beacon-chain-tests:
|
|
name: beacon-chain-tests
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install Protoc
|
|
uses: arduino/setup-protoc@e52d9eb8f7b63115df1ac544a1376fdbf5a39612
|
|
with:
|
|
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: Run beacon_chain tests for all known forks
|
|
run: make test-beacon-chain
|
|
op-pool-tests:
|
|
name: op-pool-tests
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install Protoc
|
|
uses: arduino/setup-protoc@e52d9eb8f7b63115df1ac544a1376fdbf5a39612
|
|
with:
|
|
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: Run operation_pool tests for all known forks
|
|
run: make test-op-pool
|
|
slasher-tests:
|
|
name: slasher-tests
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Run slasher tests for all supported backends
|
|
run: make test-slasher
|
|
debug-tests-ubuntu:
|
|
name: debug-tests-ubuntu
|
|
runs-on: ubuntu-22.04
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install Protoc
|
|
uses: arduino/setup-protoc@e52d9eb8f7b63115df1ac544a1376fdbf5a39612
|
|
with:
|
|
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: Install ganache
|
|
run: sudo npm install -g ganache
|
|
- name: Run tests in debug
|
|
run: make test-debug
|
|
state-transition-vectors-ubuntu:
|
|
name: state-transition-vectors-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install Protoc
|
|
uses: arduino/setup-protoc@e52d9eb8f7b63115df1ac544a1376fdbf5a39612
|
|
with:
|
|
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: Run state_transition_vectors in release.
|
|
run: make run-state-transition-tests
|
|
ef-tests-ubuntu:
|
|
name: ef-tests-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install Protoc
|
|
uses: arduino/setup-protoc@e52d9eb8f7b63115df1ac544a1376fdbf5a39612
|
|
with:
|
|
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: Run consensus-spec-tests with blst, milagro and fake_crypto
|
|
run: make test-ef
|
|
dockerfile-ubuntu:
|
|
name: dockerfile-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Build the root Dockerfile
|
|
run: docker build --build-arg FEATURES=portable -t lighthouse:local .
|
|
- name: Test the built image
|
|
run: docker run -t lighthouse:local lighthouse --version
|
|
eth1-simulator-ubuntu:
|
|
name: eth1-simulator-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install Protoc
|
|
uses: arduino/setup-protoc@e52d9eb8f7b63115df1ac544a1376fdbf5a39612
|
|
with:
|
|
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: Install ganache
|
|
run: sudo npm install -g ganache
|
|
- name: Run the beacon chain sim that starts from an eth1 contract
|
|
run: cargo run --release --bin simulator eth1-sim
|
|
merge-transition-ubuntu:
|
|
name: merge-transition-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install Protoc
|
|
uses: arduino/setup-protoc@e52d9eb8f7b63115df1ac544a1376fdbf5a39612
|
|
with:
|
|
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: Install ganache
|
|
run: sudo npm install -g ganache
|
|
- name: Run the beacon chain sim and go through the merge transition
|
|
run: cargo run --release --bin simulator eth1-sim --post-merge
|
|
no-eth1-simulator-ubuntu:
|
|
name: no-eth1-simulator-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install Protoc
|
|
uses: arduino/setup-protoc@e52d9eb8f7b63115df1ac544a1376fdbf5a39612
|
|
with:
|
|
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: Install ganache
|
|
run: sudo npm install -g ganache
|
|
- name: Run the beacon chain sim without an eth1 connection
|
|
run: cargo run --release --bin simulator no-eth1-sim
|
|
syncing-simulator-ubuntu:
|
|
name: syncing-simulator-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install Protoc
|
|
uses: arduino/setup-protoc@e52d9eb8f7b63115df1ac544a1376fdbf5a39612
|
|
with:
|
|
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: Install ganache
|
|
run: sudo npm install -g ganache
|
|
- name: Run the syncing simulator
|
|
run: cargo run --release --bin simulator syncing-sim
|
|
doppelganger-protection-test:
|
|
name: doppelganger-protection-test
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install Protoc
|
|
uses: arduino/setup-protoc@e52d9eb8f7b63115df1ac544a1376fdbf5a39612
|
|
with:
|
|
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: Install ganache
|
|
run: sudo npm install -g ganache
|
|
- name: Install lighthouse and lcli
|
|
run: |
|
|
make
|
|
make install-lcli
|
|
- name: Run the doppelganger protection success test script
|
|
run: |
|
|
cd scripts/tests
|
|
./doppelganger_protection.sh success
|
|
- name: Run the doppelganger protection failure test script
|
|
run: |
|
|
cd scripts/tests
|
|
./doppelganger_protection.sh failure
|
|
execution-engine-integration-ubuntu:
|
|
name: execution-engine-integration-ubuntu
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- uses: actions/setup-go@v3
|
|
with:
|
|
go-version: '1.20'
|
|
- uses: actions/setup-dotnet@v3
|
|
with:
|
|
dotnet-version: '6.0.201'
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install Protoc
|
|
uses: arduino/setup-protoc@e52d9eb8f7b63115df1ac544a1376fdbf5a39612
|
|
with:
|
|
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: Run exec engine integration tests in release
|
|
run: make test-exec-engine
|
|
check-benchmarks:
|
|
name: check-benchmarks
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install Protoc
|
|
uses: arduino/setup-protoc@e52d9eb8f7b63115df1ac544a1376fdbf5a39612
|
|
with:
|
|
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: Typecheck benchmark code without running it
|
|
run: make check-benches
|
|
clippy:
|
|
name: clippy
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Install Protoc
|
|
uses: arduino/setup-protoc@e52d9eb8f7b63115df1ac544a1376fdbf5a39612
|
|
with:
|
|
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: Lint code for quality and style with Clippy
|
|
run: make lint
|
|
- name: Certify Cargo.lock freshness
|
|
run: git diff --exit-code Cargo.lock
|
|
check-msrv:
|
|
name: check-msrv
|
|
runs-on: ubuntu-latest
|
|
needs: [cargo-fmt, extract-msrv]
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Install Rust @ MSRV (${{ needs.extract-msrv.outputs.MSRV }})
|
|
run: rustup override set ${{ needs.extract-msrv.outputs.MSRV }}
|
|
- name: Install Protoc
|
|
uses: arduino/setup-protoc@e52d9eb8f7b63115df1ac544a1376fdbf5a39612
|
|
with:
|
|
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: Run cargo check
|
|
run: cargo check --workspace
|
|
arbitrary-check:
|
|
name: arbitrary-check
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Validate state_processing feature arbitrary-fuzz
|
|
run: make arbitrary-fuzz
|
|
cargo-audit:
|
|
name: cargo-audit
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Get latest version of stable Rust
|
|
run: rustup update stable
|
|
- name: Run cargo audit to identify known security vulnerabilities reported to the RustSec Advisory Database
|
|
run: make audit
|
|
cargo-vendor:
|
|
name: cargo-vendor
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Run cargo vendor to make sure dependencies can be vendored for packaging, reproducibility and archival purpose
|
|
run: CARGO_HOME=$(readlink -f $HOME) make vendor
|
|
cargo-udeps:
|
|
name: cargo-udeps
|
|
runs-on: ubuntu-latest
|
|
needs: cargo-fmt
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Install Rust (${{ env.PINNED_NIGHTLY }})
|
|
run: rustup toolchain install $PINNED_NIGHTLY
|
|
- name: Install Protoc
|
|
uses: arduino/setup-protoc@e52d9eb8f7b63115df1ac544a1376fdbf5a39612
|
|
with:
|
|
repo-token: ${{ secrets.GITHUB_TOKEN }}
|
|
- name: Install cargo-udeps
|
|
run: cargo install cargo-udeps --locked --force
|
|
- name: Create Cargo config dir
|
|
run: mkdir -p .cargo
|
|
- name: Install custom Cargo config
|
|
run: cp -f .github/custom/config.toml .cargo/config.toml
|
|
- name: Run cargo udeps to identify unused crates in the dependency graph
|
|
run: make udeps
|
|
env:
|
|
# Allow warnings on Nightly
|
|
RUSTFLAGS: ""
|
|
compile-with-beta-compiler:
|
|
name: compile-with-beta-compiler
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Install dependencies
|
|
run: sudo apt install -y git gcc g++ make cmake pkg-config llvm-dev libclang-dev clang protobuf-compiler
|
|
- name: Use Rust beta
|
|
run: rustup override set beta
|
|
- name: Run make
|
|
run: make
|