lighthouse/beacon_node/network/src
realbigsean 42da392edc fix deneb sync bug (#4869)
## Issue Addressed

I observed our forward sync on devnet 9 would stall when we would hit this log:
```
250425:Oct 19 00:54:17.133 WARN Blocks and blobs request for range received invalid data, error: KzgCommitmentMismatch, batch_id: 4338, peer_id: 16Uiu2HAmHbmkEQFDrJfNuy1aYyAfHkNUwSD9FN7EVAqGJ8YTF9Mh, service: sync, module: network::sync::manager:1036
```

## Proposed Changes

`range_sync_block_and_blob_response` [here](1cb02a13a5/beacon_node/network/src/sync/manager.rs (L1013)) removes the request from the sync manager. later, however if there's an error, `inject_error` [here](1cb02a13a5/beacon_node/network/src/sync/manager.rs (L1055)) expects the request to exist so we can handle retry logic. So this PR just re-inserts the request (withthout any accumulated blobs or blocks) when we hit an error here.

The issue is unique to block+blob sync because the error here is only possible from mismatches between blocks + blobs after we've downloaded both, there's no equivalent error in block sync



Co-authored-by: realbigsean <seananderson33@gmail.com>
2023-10-31 21:04:18 +00:00
..
network_beacon_processor Activate clippy::manual_let_else lint (#4889) 2023-10-31 10:31:02 +00:00
service Remove deficit gossipsub scoring during topic transition (#4486) 2023-10-04 00:43:28 +00:00
subnet_service Do not log slot clock error prior to genesis (#4657) 2023-08-28 00:55:32 +00:00
sync fix deneb sync bug (#4869) 2023-10-31 21:04:18 +00:00
error.rs Rename eth2_libp2p to lighthouse_network (#2702) 2021-10-19 00:30:39 +00:00
lib.rs Move the BeaconProcessor into a new crate (#4435) 2023-07-10 07:45:54 +00:00
metrics.rs Reduce calls to network channel (#4863) 2023-10-20 19:42:47 +00:00
nat.rs Add Experimental QUIC support (#4577) 2023-09-15 03:07:24 +00:00
persisted_dht.rs Rename eth2_libp2p to lighthouse_network (#2702) 2021-10-19 00:30:39 +00:00
router.rs Very minor own nitpicks (#4845) 2023-10-16 16:30:14 +11:00
service.rs fix typos (#4838) 2023-10-19 22:05:15 +00:00
status.rs enable 4844 at epoch 3 2022-09-18 12:13:03 +02:00