lighthouse/testing
Paul Hauner 931daa40d7 Add fork choice EF tests (#2737)
## Issue Addressed

Resolves #2545

## Proposed Changes

Adds the long-overdue EF tests for fork choice. Although we had pretty good coverage via other implementations that closely followed our approach, it is nonetheless important for us to implement these tests too.

During testing I found that we were using a hard-coded `SAFE_SLOTS_TO_UPDATE_JUSTIFIED` value rather than one from the `ChainSpec`. This caused a failure during a minimal preset test. This doesn't represent a risk to mainnet or testnets, since the hard-coded value matched the mainnet preset.

## Failing Cases

There is one failing case which is presently marked as `SkippedKnownFailure`:

```
case 4 ("new_finalized_slot_is_justified_checkpoint_ancestor") from /home/paul/development/lighthouse/testing/ef_tests/consensus-spec-tests/tests/minimal/phase0/fork_choice/on_block/pyspec_tests/new_finalized_slot_is_justified_checkpoint_ancestor failed with NotEqual:
head check failed: Got Head { slot: Slot(40), root: 0x9183dbaed4191a862bd307d476e687277fc08469fc38618699863333487703e7 } | Expected Head { slot: Slot(24), root: 0x105b49b51bf7103c182aa58860b039550a89c05a4675992e2af703bd02c84570 }
```

This failure is due to #2741. It's not a particularly high priority issue at the moment, so we fix it after merging this PR.
2021-11-08 07:29:04 +00:00
..
ef_tests Add fork choice EF tests (#2737) 2021-11-08 07:29:04 +00:00
eth1_test_rig Remove unused deps (#2592) 2021-09-30 04:31:42 +00:00
node_test_rig Remove unused deps (#2592) 2021-09-30 04:31:42 +00:00
simulator Resolve Rust 1.56 lints and warnings (#2728) 2021-10-19 00:30:42 +00:00
state_transition_vectors Add BeaconChainHarness::builder (#2707) 2021-10-14 02:58:10 +00:00
test-test_logger Add test_logger as feature to logging (#2586) 2021-10-06 00:46:07 +00:00
web3signer_tests Add note about java dependency (#2746) 2021-10-25 22:11:26 +00:00