lighthouse/testing
Michael Sproul 4bd2b777ec Verify execution block hashes during finalized sync (#3794)
## Issue Addressed

Recent discussions with other client devs about optimistic sync have revealed a conceptual issue with the optimisation implemented in #3738. In designing that feature I failed to consider that the execution node checks the `blockHash` of the execution payload before responding with `SYNCING`, and that omitting this check entirely results in a degradation of the full node's validation. A node omitting the `blockHash` checks could be tricked by a supermajority of validators into following an invalid chain, something which is ordinarily impossible.

## Proposed Changes

I've added verification of the `payload.block_hash` in Lighthouse. In case of failure we log a warning and fall back to verifying the payload with the execution client.

I've used our existing dependency on `ethers_core` for RLP support, and a new dependency on Parity's `triehash` crate for the Merkle patricia trie. Although the `triehash` crate is currently unmaintained it seems like our best option at the moment (it is also used by Reth, and requires vastly less boilerplate than Parity's generic `trie-root` library).

Block hash verification is pretty quick, about 500us per block on my machine (mainnet).

The optimistic finalized sync feature can be disabled using `--disable-optimistic-finalized-sync` which forces full verification with the EL.

## Additional Info

This PR also introduces a new dependency on our [`metastruct`](https://github.com/sigp/metastruct) library, which was perfectly suited to the RLP serialization method. There will likely be changes as `metastruct` grows, but I think this is a good way to start dogfooding it.

I took inspiration from some Parity and Reth code while writing this, and have preserved the relevant license headers on the files containing code that was copied and modified.
2023-01-09 03:11:59 +00:00
..
antithesis Fix antithesis docker builds (#3380) 2022-07-28 07:40:03 +00:00
ef_tests Verify execution block hashes during finalized sync (#3794) 2023-01-09 03:11:59 +00:00
eth1_test_rig Fix ganache test endpoint for ipv6 machines (#3563) 2022-09-13 01:57:45 +00:00
execution_engine_integration Verify execution block hashes during finalized sync (#3794) 2023-01-09 03:11:59 +00:00
node_test_rig Verify execution block hashes during finalized sync (#3794) 2023-01-09 03:11:59 +00:00
simulator Add CLI flag to opt in to world-readable log files (#3747) 2022-11-25 07:57:11 +00:00
state_transition_vectors Consensus context with proposer index caching (#3604) 2022-10-15 22:25:54 +00:00
test-test_logger Update to Rust 1.59 and 2021 edition (#3038) 2022-02-25 00:10:17 +00:00
web3signer_tests Various CI fixes (#3813) 2022-12-20 01:34:52 +00:00