lighthouse/beacon_node/http_api
Michael Sproul 74eb267643 Remove double-locking deadlock from HTTP API (#4687)
## Issue Addressed

Fix a deadlock introduced in #4236 which was caught during the v4.4.0 release testing cycle (with thanks to @paulhauner and `gdb`).

## Proposed Changes

Avoid re-locking the fork choice read lock when querying a state by root in the HTTP API. This avoids a deadlock due to the lock already being held.

## Additional Info

The [RwLock docs](https://docs.rs/lock_api/latest/lock_api/struct.RwLock.html#method.read) explicitly advise against re-locking:

> Note that attempts to recursively acquire a read lock on a RwLock when the current thread already holds one may result in a deadlock.
2023-08-31 11:18:00 +00:00
..
src Remove double-locking deadlock from HTTP API (#4687) 2023-08-31 11:18:00 +00:00
tests Send success code for duplicate blocks on HTTP (#4655) 2023-08-28 00:55:31 +00:00
Cargo.toml Use BeaconProcessor for API requests (#4462) 2023-08-08 23:30:15 +00:00