lighthouse/beacon_node/http_api
Paul Hauner 2de26b20f8 Don't return errors on HTTP API for already-known messages (#3341)
## Issue Addressed

- Resolves #3266

## Proposed Changes

Return 200 OK rather than an error when a block, attestation or sync message is already known.

Presently, we will log return an error which causes a BN to go "offline" from the VCs perspective which causes the fallback mechanism to do work to try and avoid and upcheck offline nodes. This can be observed as instability in the `vc_beacon_nodes_available_count` metric.

The current behaviour also causes scary logs for the user. There's nothing to *actually* be concerned about when we see duplicate messages, this can happen on fallback systems (see code comments).

## Additional Info

NA
2022-08-10 07:52:57 +00:00
..
src Don't return errors on HTTP API for already-known messages (#3341) 2022-08-10 07:52:57 +00:00
tests Don't use the builder network if the head is optimistic (#3412) 2022-08-09 06:05:16 +00:00
Cargo.toml Builder Specs v0.2.0 (#3134) 2022-07-30 00:22:37 +00:00