lighthouse/testing
Paul Hauner 25f0e261cb Don't return errors when fork choice fails (#3370)
## Issue Addressed

NA

## Proposed Changes

There are scenarios where the only viable head will have an invalid execution payload, in this scenario the `get_head` function on `proto_array` will return an error. We must recover from this scenario by importing blocks from the network.

This PR stops `BeaconChain::recompute_head` from returning an error so that we can't accidentally start down-scoring peers or aborting block import just because the current head has an invalid payload.

## Reviewer Notes

The following changes are included:

1. Allow `fork_choice.get_head` to fail gracefully in `BeaconChain::process_block` when trying to update the `early_attester_cache`; simply don't add the block to the cache rather than aborting the entire process.
1. Don't return an error from `BeaconChain::recompute_head_at_current_slot` and `BeaconChain::recompute_head` to defensively prevent calling functions from aborting any process just because the fork choice function failed to run.
    - This should have practically no effect, since most callers were still continuing if recomputing the head failed.
    - The outlier is that the API will return 200 rather than a 500 when fork choice fails.
1. Add the `ProtoArrayForkChoice::set_all_blocks_to_optimistic` function to recover from the scenario where we've rebooted and the persisted fork choice has an invalid head.
2022-07-28 13:57:09 +00:00
..
antithesis Fix antithesis docker builds (#3380) 2022-07-28 07:40:03 +00:00
ef_tests Don't return errors when fork choice fails (#3370) 2022-07-28 13:57:09 +00:00
eth1_test_rig Unify execution layer endpoints (#3214) 2022-06-29 09:07:09 +00:00
execution_engine_integration Downgrade Geth to v1.10.20 in EE integration tests (#3382) 2022-07-28 07:40:05 +00:00
node_test_rig Add merge support to simulator (#3292) 2022-07-18 23:15:40 +00:00
simulator Add merge support to simulator (#3292) 2022-07-18 23:15:40 +00:00
state_transition_vectors Use async code when interacting with EL (#3244) 2022-07-03 05:36:50 +00:00
test-test_logger Update to Rust 1.59 and 2021 edition (#3038) 2022-02-25 00:10:17 +00:00
web3signer_tests Allow setting web3signer version through environment (#3368) 2022-07-27 03:20:01 +00:00