lighthouse/beacon_node/execution_layer/src
Paul Hauner 9072acbfa6 Tidy formatting of Reqwest errors (#4336)
## Issue Addressed

NA

## Proposed Changes

Implements the `PrettyReqwestError` to wrap a `reqwest::Error` and give nicer `Debug` formatting. It also wraps the `Url` component in a `SensitiveUrl` to avoid leaking sensitive info in logs.

### Before

```
Reqwest(reqwest::Error { kind: Request, url: Url { scheme: "http", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("localhost")), port: Some(9999), path: "/eth/v1/node/version", query: None, fragment: None }, source: hyper::Error(Connect, ConnectError("tcp connect error", Os { code: 61, kind: ConnectionRefused, message: "Connection refused" })) })
```

### After

```
HttpClient(url: http://localhost:9999/, kind: request, detail: error trying to connect: tcp connect error: Connection refused (os error 61))
```

## Additional Info

I've also renamed the `Reqwest` error enum variants to `HttpClient`, to give people a better chance at knowing what's going on. Reqwest is pretty odd and looks like a typo.

I've implemented it in the `eth2` and `execution_layer` crates. This should affect most logs in the VC and EE-related ones in the BN.

I think the last crate that could benefit from the is the `beacon_node/eth1` crate. I haven't updated it in this PR since its error type is not so amenable to it (everything goes into a `String`). I don't have a whole lot of time to jig around with that at the moment and I feel that this PR as it stands is a significant enough improvement to merge on its own. Leaving it as-is is fine for the time being and we can always come back for it later (or implement in-protocol deposits!).
2023-06-27 01:06:50 +00:00
..
engine_api Split common crates out into their own repos (#3890) 2023-04-28 01:15:40 +00:00
test_utils Implement el_offline and use it in the VC (#4295) 2023-05-17 05:51:56 +00:00
block_hash.rs Expose execution block hash calculation (#4326) 2023-06-02 03:17:37 +00:00
engine_api.rs Tidy formatting of Reqwest errors (#4336) 2023-06-27 01:06:50 +00:00
engines.rs Implement el_offline and use it in the VC (#4295) 2023-05-17 05:51:56 +00:00
keccak.rs Verify execution block hashes during finalized sync (#3794) 2023-01-09 03:11:59 +00:00
lib.rs Always log the value of relay and local blocks for comparison (#4352) 2023-06-07 01:50:31 +00:00
metrics.rs Reconstruct Payloads using Payload Bodies Methods (#4028) 2023-03-19 23:15:59 +00:00
payload_cache.rs Keep payload cache idempotent (#4256) 2023-05-30 01:38:45 +00:00
payload_status.rs Permit a null LVH from an INVALID response to newPayload (#4037) 2023-03-03 04:12:50 +00:00