lighthouse/consensus
Paul Hauner 1f8c17b530 Fork choice modifications and cleanup (#3962)
## Issue Addressed

NA

## Proposed Changes

- Implements https://github.com/ethereum/consensus-specs/pull/3290/
- Bumps `ef-tests` to [v1.3.0-rc.4](https://github.com/ethereum/consensus-spec-tests/releases/tag/v1.3.0-rc.4).

The `CountRealizedFull` concept has been removed and the `--count-unrealized-full` and `--count-unrealized` BN flags now do nothing but log a `WARN` when used.

## Database Migration Debt

This PR removes the `best_justified_checkpoint` from fork choice. This field is persisted on-disk and the correct way to go about this would be to make a DB migration to remove the field. However, in this PR I've simply stubbed out the value with a junk value. I've taken this approach because if we're going to do a DB migration I'd love to remove the `Option`s around the justified and finalized checkpoints on `ProtoNode` whilst we're at it. Those options were added in #2822 which was included in Lighthouse v2.1.0. The options were only put there to handle the migration and they've been set to `Some` ever since v2.1.0. There's no reason to keep them as options anymore.

I started adding the DB migration to this branch but I started to feel like I was bloating this rather critical PR with nice-to-haves. I've kept the partially-complete migration [over in my repo](https://github.com/paulhauner/lighthouse/tree/fc-pr-18-migration) so we can pick it up after this PR is merged.
2023-03-21 07:34:41 +00:00
..
cached_tree_hash Merge remote-tracking branch 'origin/unstable' into capella 2023-01-12 16:22:00 +11:00
fork_choice Fork choice modifications and cleanup (#3962) 2023-03-21 07:34:41 +00:00
int_to_bytes Update to Rust 1.59 and 2021 edition (#3038) 2022-02-25 00:10:17 +00:00
merkle_proof Verify execution block hashes during finalized sync (#3794) 2023-01-09 03:11:59 +00:00
proto_array Fork choice modifications and cleanup (#3962) 2023-03-21 07:34:41 +00:00
safe_arith Inline safe_arith methods (#3229) 2022-05-31 06:09:12 +00:00
serde_utils Tweaks to reward APIs (#3957) 2023-02-10 06:19:42 +00:00
ssz Merge remote-tracking branch 'origin/unstable' into capella 2023-01-12 16:22:00 +11:00
ssz_derive Appease Clippy 1.68 and refactor http_api (#4068) 2023-03-13 01:40:03 +00:00
ssz_types Suggestions for Capella execution_layer (#3983) 2023-02-17 11:58:33 +11:00
state_processing Clean capella (#4019) 2023-03-01 03:19:02 +00:00
swap_or_not_shuffle Verify execution block hashes during finalized sync (#3794) 2023-01-09 03:11:59 +00:00
tree_hash Merge remote-tracking branch 'origin/unstable' into capella 2023-01-12 16:22:00 +11:00
tree_hash_derive Appease Clippy 1.68 and refactor http_api (#4068) 2023-03-13 01:40:03 +00:00
types Set Capella fork epoch for Mainnet (#4111) 2023-03-21 05:15:01 +00:00