lighthouse/consensus
Michael Sproul 0866b739d0 Clippy 1.67 (#3916)
## Proposed Changes

Clippy 1.67.0 put us on blast for the size of some of our errors, most of them written by me ( 👀 ). This PR shrinks the size of `BeaconChainError` by dropping some extraneous info and boxing an inner error which should only occur infrequently anyway.

For the `AttestationSlashInfo` and `BlockSlashInfo` I opted to ignore the lint as they are always used in a `Result<A, Info>` where `A` is a similar size. This means they don't bloat the size of the `Result`, so it's a bit annoying for Clippy to report this as an issue.

I also chose to ignore `clippy::uninlined-format-args` because I think the benefit-to-churn ratio is too low. E.g. sometimes we have long identifiers in `format!` args and IMO the non-inlined form is easier to read:

```rust
// I prefer this...
format!(
    "{} did {} to {}",
    REALLY_LONG_CONSTANT_NAME,
    ANOTHER_REALLY_LONG_CONSTANT_NAME,
    regular_long_identifier_name
);
  
// To this
format!("{REALLY_LONG_CONSTANT_NAME} did {ANOTHER_REALLY_LONG_CONSTANT_NAME} to {regular_long_identifier_name}");
```

I tried generating an automatic diff with `cargo clippy --fix` but it came out at:

```
250 files changed, 1209 insertions(+), 1469 deletions(-)
```

Which seems like a bad idea when we'd have to back-merge it to `capella` and `eip4844` 😱
2023-01-27 09:48:42 +00:00
..
cached_tree_hash Verify execution block hashes during finalized sync (#3794) 2023-01-09 03:11:59 +00:00
fork_choice Enable proposer boost re-orging (#2860) 2022-12-13 09:57:26 +00:00
int_to_bytes Update to Rust 1.59 and 2021 edition (#3038) 2022-02-25 00:10:17 +00:00
merkle_proof Verify execution block hashes during finalized sync (#3794) 2023-01-09 03:11:59 +00:00
proto_array Enable proposer boost re-orging (#2860) 2022-12-13 09:57:26 +00:00
safe_arith Inline safe_arith methods (#3229) 2022-05-31 06:09:12 +00:00
serde_utils Verify execution block hashes during finalized sync (#3794) 2023-01-09 03:11:59 +00:00
ssz Verify execution block hashes during finalized sync (#3794) 2023-01-09 03:11:59 +00:00
ssz_derive Update to Rust 1.59 and 2021 edition (#3038) 2022-02-25 00:10:17 +00:00
ssz_types Prioritise important parts of block processing (#3696) 2022-11-30 05:22:58 +00:00
state_processing Clippy 1.67 (#3916) 2023-01-27 09:48:42 +00:00
swap_or_not_shuffle Verify execution block hashes during finalized sync (#3794) 2023-01-09 03:11:59 +00:00
tree_hash Verify execution block hashes during finalized sync (#3794) 2023-01-09 03:11:59 +00:00
tree_hash_derive Use SmallVec for TreeHash packed encoding (#3581) 2022-09-16 08:54:06 +00:00
types Verify execution block hashes during finalized sync (#3794) 2023-01-09 03:11:59 +00:00