Commit Graph

248 Commits

Author SHA1 Message Date
blacktemplar
01054ecf2f Use SignatureBytes and PublicKeyBytes for deposits (#472)
* Replace deposit signatures with SignatureBytes, a struct which lazyly parsers signatures only on demand.

* check byte length when parsing SignatureBytes

* add comment to struct

* distinguish BadSignature and BadSignatureBytes in verify_deposit_signature

* add test for valid signature

* Implements TryInto<Signature> for &SignatureBytes and From<Signature> for &SignatureBytes

* add and use PublicKeyBytes + fix formatting

* fix compiler warning + docs for macro generated structs

* adds tests to ensure correct byte lengths

* small style improvement as suggested by michaelsproul
2019-08-06 13:49:11 +10:00
Paul Hauner
81a089aa8b
Remove old benches (#465)
* Remove cached_tree_hash benches

* Remove state_processing benches
2019-07-30 17:19:03 +10:00
Michael Sproul
eb669ab40f
Add v0.8 genesis tests (#466)
Closes #452
2019-07-30 17:02:38 +10:00
Michael Sproul
a236003a7b Update to frozen spec ❄️ (v0.8.1) (#444)
* types: first updates for v0.8

* state_processing: epoch processing v0.8.0

* state_processing: block processing v0.8.0

* tree_hash_derive: support generics in SignedRoot

* types v0.8: update to use ssz_types

* state_processing v0.8: use ssz_types

* ssz_types: add bitwise methods and from_elem

* types: fix v0.8 FIXMEs

* ssz_types: add bitfield shift_up

* ssz_types: iterators and DerefMut for VariableList

* types,state_processing: use VariableList

* ssz_types: fix BitVector Decode impl

Fixed a typo in the implementation of ssz::Decode for BitVector, which caused it
to be considered variable length!

* types: fix test modules for v0.8 update

* types: remove slow type-level arithmetic

* state_processing: fix tests for v0.8

* op_pool: update for v0.8

* ssz_types: Bitfield difference length-independent

Allow computing the difference of two bitfields of different lengths.

* Implement compact committee support

* epoch_processing: committee & active index roots

* state_processing: genesis state builder v0.8

* state_processing: implement v0.8.1

* Further improve tree_hash

* Strip examples, tests from cached_tree_hash

* Update TreeHash, un-impl CachedTreeHash

* Update bitfield TreeHash, un-impl CachedTreeHash

* Update FixedLenVec TreeHash, unimpl CachedTreeHash

* Update update tree_hash_derive for new TreeHash

* Fix TreeHash, un-impl CachedTreeHash for ssz_types

* Remove fixed_len_vec, ssz benches

SSZ benches relied upon fixed_len_vec -- it is easier to just delete
them and rebuild them later (when necessary)

* Remove boolean_bitfield crate

* Fix fake_crypto BLS compile errors

* Update ef_tests for new v.8 type params

* Update ef_tests submodule to v0.8.1 tag

* Make fixes to support parsing ssz ef_tests

* `compact_committee...` to `compact_committees...`

* Derive more traits for `CompactCommittee`

* Flip bitfield byte-endianness

* Fix tree_hash for bitfields

* Modify CLI output for ef_tests

* Bump ssz crate version

* Update ssz_types doc comment

* Del cached tree hash tests from ssz_static tests

* Tidy SSZ dependencies

* Rename ssz_types crate to eth2_ssz_types

* validator_client: update for v0.8

* ssz_types: update union/difference for bit order swap

* beacon_node: update for v0.8, EthSpec

* types: disable cached tree hash, update min spec

* state_processing: fix slot bug in committee update

* tests: temporarily disable fork choice harness test

See #447

* committee cache: prevent out-of-bounds access

In the case where we tried to access the committee of a shard that didn't have a committee in the
current epoch, we were accessing elements beyond the end of the shuffling vector and panicking! This
commit adds a check to make the failure safe and explicit.

* fix bug in get_indexed_attestation and simplify

There was a bug in our implementation of get_indexed_attestation whereby
incorrect "committee indices" were used to index into the custody bitfield. The
bug was only observable in the case where some bits of the custody bitfield were
set to 1. The implementation has been simplified to remove the bug, and a test
added.

* state_proc: workaround for compact committees bug

https://github.com/ethereum/eth2.0-specs/issues/1315

* v0.8: updates to make the EF tests pass

* Remove redundant max operation checks.
* Always supply both messages when checking attestation signatures -- allowing
  verification of an attestation with no signatures.
* Swap the order of the fork and domain constant in `get_domain`, to match
  the spec.

* rustfmt

* ef_tests: add new epoch processing tests

* Integrate v0.8 into master (compiles)

* Remove unused crates, fix clippy lints

* Replace v0.6.3 tags w/ v0.8.1

* Remove old comment

* Ensure lmd ghost tests only run in release

* Update readme
2019-07-30 12:44:51 +10:00
John Adler
1b26a36ebc Verify transfer now checks for amount + fees. (#457) 2019-07-29 12:17:04 +10:00
Pawan Dhananjay
db094022b9 Remove unused dependencies (#456) 2019-07-29 09:55:57 +10:00
John Adler
fec7168512
Fix lots of typos. 2019-07-26 15:26:06 -04:00
Paul Hauner
027f0a539d
Prepare ssz for publishing on crates.io 2019-07-03 16:06:20 +10:00
Paul Hauner
5a98502ad6
Fix bug in epoch trans. finalization 2019-06-24 09:34:53 +10:00
Paul Hauner
25e93f60fd
Tidy comments 2019-06-17 10:01:23 -04:00
Michael Sproul
9cec5dc073
process slashings: fix subtraction overflow 2019-06-17 17:22:48 +10:00
Michael Sproul
03c50354f4
v0.6: update all spec version comments 2019-06-17 17:22:48 +10:00
Paul Hauner
a71f05066b
Merge branch 'docker-env' into v0.6.1 2019-06-13 10:37:35 -04:00
Michael Sproul
44bccda4b3
epoch proc: set correct active index root 2019-06-12 15:39:48 +10:00
Paul Hauner
e550c0218f
Add various fixes to clippy lints
Thou shalt appease clippy
2019-06-10 11:01:25 -04:00
Paul Hauner
a662c3a940
Fix various compile errors and warnings 2019-06-09 06:26:34 -04:00
Paul Hauner
ab12787610
Update account manager config parsing 2019-06-09 04:34:56 -04:00
Paul Hauner
d8fc5f31d8
Add Eth2Config to runtime 2019-06-08 13:17:03 -04:00
Paul Hauner
749f2fcb5f
Unify EthSpecs in Mainnet and Minimal 2019-06-08 08:49:04 -04:00
Paul Hauner
caddeba81b
Remove genesis_epoch from ChainSpec 2019-06-08 08:17:42 -04:00
Paul Hauner
e74d49fc8a
Remove dupe info between ChainSpec and EthSpec 2019-06-08 07:57:25 -04:00
Paul Hauner
719dd72de6
Fix recently introduced sync bugs 2019-06-07 02:55:16 -04:00
Michael Sproul
b9f0348930
epoch processing: fix inclusion info proposer idx 2019-06-04 17:10:18 +10:00
Michael Sproul
49e19e2b7d
state_proc: verify sig in process_block_header 2019-06-04 16:37:36 +10:00
Paul Hauner
47128ea834
Fix bug in proposer rewards 2019-06-04 15:00:52 +10:00
Paul Hauner
50dd963fdd
Fix bug in epoch_processing 2019-06-04 14:16:45 +10:00
Michael Sproul
10884359af
spec v0.6: check custody bitfield length 2019-06-04 11:04:53 +10:00
Michael Sproul
6bde64bd6a
spec v0.6: update beacon_node, validator_client 2019-06-03 16:13:51 +10:00
Michael Sproul
7fbcdd54d7
op_pool: update for v0.6.x 2019-06-03 15:25:06 +10:00
Paul Hauner
e310bdd904
Merge branch 'master' into v0.6.1 2019-06-02 13:49:24 +10:00
Michael Sproul
83456c6894
fixup: remove some unused variables 2019-05-29 16:36:50 +10:00
Michael Sproul
37c67117d3
state_processing: remove spurious withdrawal credentials check 2019-05-29 10:56:21 +10:00
Michael Sproul
01039546cb
state_processing: sort attester slashing indices
This will be "to spec" if eth2.0-specs#1126 is merged
2019-05-27 17:46:05 +10:00
Paul Hauner
a92c209787
Rename file in state_processing 2019-05-24 14:08:19 +10:00
Paul Hauner
99ae734638
Add saturating sub to slash_validator 2019-05-24 14:08:19 +10:00
Paul Hauner
55ef75a44e
Fix underflow in verify_indexed_attestation 2019-05-24 14:08:19 +10:00
Paul Hauner
cc916e25fd
Fix erroneous change related to max_transfers 2019-05-23 23:28:03 +10:00
Paul Hauner
29792c56d5
Fix bug with checking for dust in transfers 2019-05-23 16:52:20 +10:00
Paul Hauner
4db6a8a058
Add transfer ef tests 2019-05-23 08:48:09 +10:00
Paul Hauner
892d891977
Fix bugs in deposit processing 2019-05-22 18:54:26 +10:00
Paul Hauner
2cffca7b1a
Enable merkle branch verification for deposits 2019-05-22 16:46:27 +10:00
Paul Hauner
9790968378
Remove old inclusion_distance file 2019-05-22 12:19:13 +10:00
Paul Hauner
987afb6595
Update some Spec v.. comments & minor logic fix 2019-05-22 12:17:56 +10:00
Paul Hauner
ea36c5ad35
Remove update_registry_and_shuffling_data 2019-05-22 12:17:00 +10:00
Paul Hauner
350dc1ad80
Add type hint to hashset AND. 2019-05-22 11:45:05 +10:00
Paul Hauner
04791dfc58
Update verify_exit to spec v0.6.1 2019-05-22 11:45:01 +10:00
Paul Hauner
bb7ee642d8
Update verify_transfer to spec v0.6.1 2019-05-22 11:28:29 +10:00
Michael Sproul
545fb10005
spec v0.6.1: deposit processing (WIP) 2019-05-21 18:02:31 +10:00
Michael Sproul
468dc2ceb0
per-block processing: minor fixups 2019-05-21 16:43:55 +10:00
Michael Sproul
0b2aa26f2d
spec v0.6.1: attestation processing/verif 2019-05-21 16:43:55 +10:00