Age Manning
528f7181bc
Improve block delay metrics ( #3894 )
...
We recently ran a large-block experiment on the testnet and plan to do a further experiment on mainnet.
Although the metrics recovered from lighthouse nodes were quite useful, I think we could do with greater resolution in the block delay metrics and get some specific values for each block (currently these can be lost to large exponential histogram buckets).
This PR increases the resolution of the block delay histogram buckets, but also introduces a new metric which records the last block delay. Depending on the polling resolution of the metric server, we can lose some block delay information, however it will always give us a specific value and we will not lose exact data based on poor resolution histogram buckets.
2023-01-25 14:21:53 +01:00
Santiago Medina
bd7bd005ee
Return HTTP 404 rather than 405 ( #3836 )
...
Issue #3112
Add `Filter::recover` to the GET chain to handle rejections specifically as 404 NOT FOUND
Making a request to `http://localhost:5052/not_real ` now returns the following:
```
{
"code": 404,
"message": "NOT_FOUND",
"stacktraces": []
}
```
Co-authored-by: Paul Hauner <paul@paulhauner.com>
2023-01-25 14:21:07 +01:00
realbigsean
5e8d79891b
merge conflict resolution
2023-01-25 11:10:44 +01:00
realbigsean
9fde813a7e
Merge pull request #3913 from divagant-martian/reject-pre-fork-rpc-upgrades
...
only support 4844 rpc methods if on 4844
2023-01-25 10:56:56 +01:00
realbigsean
d3240c1ffb
fix common issue across blocks by range and blobs by range
2023-01-24 15:42:28 +01:00
realbigsean
18d4faf611
review updates
2023-01-24 15:30:29 +01:00
realbigsean
2225e6ac89
pass in data availability boundary to the get_blobs method
2023-01-24 14:35:07 +01:00
realbigsean
a4ea1761bb
Update beacon_node/beacon_chain/src/beacon_chain.rs
2023-01-24 12:28:58 +01:00
realbigsean
5b4cd997d0
Update beacon_node/lighthouse_network/src/rpc/methods.rs
2023-01-24 12:20:40 +01:00
Diva M
2d2da92132
only support 4844 rpc methods if on 4844
2023-01-24 05:15:23 -05:00
realbigsean
b658cc7aaf
simplify checking attester cache for block and blobs. use ResourceUnavailable according to the spec
2023-01-24 10:50:47 +01:00
Emilia Hane
e14550425d
Fix mismatched response bug
2023-01-23 13:23:04 +01:00
realbigsean
4a51f65ce2
move available block comment
2023-01-23 09:17:57 +01:00
realbigsean
75320ff8bc
cleanup
2023-01-22 05:54:25 +01:00
Emilia Hane
81a754577d
fixup! Improve error handling
2023-01-21 15:47:33 +01:00
Emilia Hane
f32f08eec0
Fix typo
2023-01-21 14:47:14 +01:00
Emilia Hane
5fc648217d
fixup! Improve error handling
2023-01-21 14:46:24 +01:00
realbigsean
a83fd1afb4
remove unused imports
2023-01-21 04:52:36 -05:00
realbigsean
cbd09dc281
finish refactor
2023-01-21 04:48:25 -05:00
realbigsean
eb9feed784
add new traits
2023-01-20 16:04:35 -05:00
Emilia Hane
f7eb89ddd9
Improve error handling
2023-01-20 21:16:47 +01:00
realbigsean
8e57eef0ed
return a BlobsUnavailable error when the block root is a pre-4844 block
2023-01-20 21:16:47 +01:00
realbigsean
c6479444c2
don't send errors when we *correctly* don't have blobs
2023-01-20 21:16:47 +01:00
realbigsean
e1ce4e5b78
make explicity BlobsUnavailable error and handle it directly
2023-01-20 21:16:47 +01:00
realbigsean
f7f64eb007
fix/consolidate some error handling
2023-01-20 21:16:47 +01:00
Emilia Hane
89cb58d17b
Fix typo
...
Co-authored-by: realbigsean <seananderson33@GMAIL.com>
2023-01-20 21:16:47 +01:00
Emilia Hane
9cc25162e2
Send error message if eip4844 fork disabled
...
Co-authored-by: realbigsean <seananderson33@GMAIL.com>
2023-01-20 21:16:46 +01:00
Emilia Hane
654e59cbba
Fix rename fn bug
...
Co-authored-by: realbigsean <seananderson33@GMAIL.com>
2023-01-20 21:16:46 +01:00
Emilia Hane
a00b355800
fixup! Less strict handling of faulty rpc req params and syntax improvement
2023-01-20 21:16:46 +01:00
Emilia Hane
b4ec4c1ccf
Less strict handling of faulty rpc req params and syntax improvement
2023-01-20 21:16:46 +01:00
Emilia Hane
9445ac70d8
Check data availability boundary in rpc request
2023-01-20 21:16:46 +01:00
realbigsean
3cb8fb7973
block wrapper refactor initial commit
2023-01-20 11:50:16 -05:00
realbigsean
8f8b7211d0
execution API related fixes
2023-01-19 09:32:08 -05:00
realbigsean
acbbdd8b9e
merge eip4844
2023-01-19 08:46:38 -05:00
Pawan Dhananjay
f04486dc71
Update kzg library to use bytes only interface
2023-01-17 12:12:17 +05:30
realbigsean
ddcd10b194
merge latest capella changes
2023-01-16 09:17:18 -05:00
ethDreamer
51088725fb
CL-EL withdrawals harmonization using Gwei units ( #3884 )
2023-01-16 12:03:42 +11:00
realbigsean
48a8cbbc45
Merge pull request #3877 from michaelsproul/withdrawals-block-hash
...
Verify blockHash with withdrawals
2023-01-13 15:12:58 -05:00
realbigsean
1319683736
Update gossip_methods.rs
2023-01-13 14:59:03 -05:00
Mark Mackey
05c1291d8a
Don't Penalize Early bls_to_execution_change
2023-01-13 12:53:25 -06:00
realbigsean
e9affafb6b
get rid of EL endpoint switching at forks
2023-01-13 10:51:45 -05:00
Michael Sproul
8e2931d73b
Verify blockHash with withdrawals
2023-01-13 12:46:54 +11:00
realbigsean
d96d793bfb
fix compilation issues
2023-01-12 14:17:14 -05:00
realbigsean
06f71e8cce
merge capella
2023-01-12 12:51:09 -05:00
Michael Sproul
aa896decc1
Fix some beacon_chain tests
2023-01-12 19:13:01 +11:00
Michael Sproul
2af8110529
Merge remote-tracking branch 'origin/unstable' into capella
...
Fixing the conflicts involved patching up some of the `block_hash` verification,
the rest will be done as part of https://github.com/sigp/lighthouse/issues/3870
2023-01-12 16:22:00 +11:00
ethDreamer
52c1055fdc
Remove withdrawals-processing feature ( #3864 )
...
* Use spec to Determine Supported Engine APIs
* Remove `withdrawals-processing` feature
* Fixed Tests
* Missed Some Spots
* Fixed Another Test
* Stupid Clippy
2023-01-12 15:15:08 +11:00
realbigsean
f7f351784a
get ef tests passing after capella rebase
2023-01-11 18:32:15 -05:00
realbigsean
438126f19a
merge upstream, fix compile errors
2023-01-11 13:52:58 -05:00
Paul Hauner
38514c07f2
Release v3.4.0 ( #3862 )
...
## Issue Addressed
NA
## Proposed Changes
Bump versions
## Additional Info
- [x] ~~Blocked on #3728 , #3801~~
- [x] ~~Blocked on #3866~~
- [x] Requires additional testing
2023-01-11 03:27:08 +00:00
