From f2aabe915b9c396af3d361498de7be7d429e8cef Mon Sep 17 00:00:00 2001 From: Justin Traglia Date: Fri, 3 Nov 2023 12:38:13 +0000 Subject: [PATCH] Fix comment for blob sidecar observation pruning (#4893) ## Issue Addressed The comment implies that observations for the given slot would be retained but they are not. ## Proposed Changes I'm pretty sure the functionality is correct and the comment is slightly incorrect, so just update the comment. The comment needs to say something along the lines of "less than or equal to" rather than just "less than." ## Additional Info It doesn't make sense to keep finalized observations since those are no longer accepted. --- beacon_node/beacon_chain/src/observed_blob_sidecars.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/beacon_node/beacon_chain/src/observed_blob_sidecars.rs b/beacon_node/beacon_chain/src/observed_blob_sidecars.rs index 6c2f07ff5..f16f38bad 100644 --- a/beacon_node/beacon_chain/src/observed_blob_sidecars.rs +++ b/beacon_node/beacon_chain/src/observed_blob_sidecars.rs @@ -87,7 +87,7 @@ impl ObservedBlobSidecars { Ok(()) } - /// Prune all values earlier than the given slot. + /// Prune `blob_sidecar` observations for slots less than or equal to the given slot. pub fn prune(&mut self, finalized_slot: Slot) { if finalized_slot == 0 { return;