From ec08b0884b7bb7b3974f7ad499c4fbbd8161de05 Mon Sep 17 00:00:00 2001 From: realbigsean Date: Mon, 21 Mar 2022 21:47:18 +0000 Subject: [PATCH] Fix ganache in windows CI (#3105) ## Issue Addressed Hopefully makes windows ganache installation more reliable. ## Proposed Changes - use `chocolatey` to install windows build tools. This seems to often be the prescribed solution for `node gyp` issues. `chocolatey` is used here because `npm install --global --production windows-build-tools` hangs in github actions ## Additional Info I still haven't found why the prior installation technique would sometimes work, the `windows-2019` environments seem to be identical across successes and failures. I think this should be re-run a few times to see if it can consistently pass Co-authored-by: realbigsean --- .github/workflows/test-suite.yml | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/.github/workflows/test-suite.yml b/.github/workflows/test-suite.yml index 16f1db0ab..1a83a753c 100644 --- a/.github/workflows/test-suite.yml +++ b/.github/workflows/test-suite.yml @@ -62,16 +62,10 @@ jobs: - uses: actions/checkout@v1 - name: Get latest version of stable Rust run: rustup update stable - - name: Add msbuild to PATH - uses: microsoft/setup-msbuild@v1.0.2 - - name: Use Python 2.7 - uses: actions/setup-python@v2 - with: - python-version: "2.7" - - name: Set node config to use python2.7 - run: npm config set python %pythonLocation% - - name: Set msvs_version to 2019 - run: npm config set msvs_version 2019 --global + - name: Install windows build tools + run: | + choco install python visualstudio2019-workload-vctools -y + npm config set msvs_version 2019 - name: Install ganache run: npm install -g ganache - name: Install make