cerc-io/lighthouse
16
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Avoid growing Vec for sync committee indices (#3301)

Browse Source 
## Issue Addressed

NA

## Proposed Changes

This is a fairly simple micro-optimization to avoid using `Vec::grow`. I don't believe this will have a substantial effect on block processing times, however it was showing up in flamegraphs. I think it's worth making this change for general memory-hygiene.

## Additional Info

NA
This commit is contained in:
Paul Hauner 2022-07-01 03:44:37 +00:00
parent a7da0677d5
commit e5212f1320
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
consensus/types/src/beacon_state.rs
View File

@ -779,14 +779,14 @@ impl<T: EthSpec> BeaconState<T> {
&mut self, &mut self,
sync_committee: &SyncCommittee<T>, sync_committee: &SyncCommittee<T>,
) -> Result<Vec<usize>, Error> { ) -> Result<Vec<usize>, Error> {
sync_committee let mut indices = Vec::with_capacity(sync_committee.pubkeys.len());
.pubkeys for pubkey in sync_committee.pubkeys.iter() {
.iter() indices.push(
.map(|pubkey| {
self.get_validator_index(pubkey)? self.get_validator_index(pubkey)?
.ok_or(Error::PubkeyCacheInconsistent) .ok_or(Error::PubkeyCacheInconsistent)?,
}) )
.collect() }
Ok(indices)
} }
/// Compute the sync committee indices for the next sync committee. /// Compute the sync committee indices for the next sync committee.