cerc-io/lighthouse
16
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Restore backwards compatibility when using older BNs (#3410)

Browse Source 
## Issue Addressed

https://github.com/status-im/nimbus-eth2/issues/3930

## Proposed Changes

We can trivially support beacon nodes which do not provide the `is_optimistic` field by wrapping the field in an `Option`.
This commit is contained in:
Mac L 2022-08-02 23:20:51 +00:00
parent d0beecca20
commit e24552d61a
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
beacon_node/http_api/src/lib.rs
View File

@ -1704,7 +1704,7 @@ pub fn serve<T: BeaconChainTypes>(
let syncing_data = api_types::SyncingData { let syncing_data = api_types::SyncingData {
is_syncing: network_globals.sync_state.read().is_syncing(), is_syncing: network_globals.sync_state.read().is_syncing(),
is_optimistic, is_optimistic: Some(is_optimistic),
head_slot, head_slot,
sync_distance, sync_distance,
}; };

2
beacon_node/http_api/tests/tests.rs
View File

@ -1300,7 +1300,7 @@ impl ApiTester {
let expected = SyncingData { let expected = SyncingData {
is_syncing: false, is_syncing: false,
is_optimistic: false, is_optimistic: Some(false),
head_slot, head_slot,
sync_distance, sync_distance,
}; };

2
common/eth2/src/types.rs
View File

@ -552,7 +552,7 @@ pub struct VersionData {
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)] #[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
pub struct SyncingData { pub struct SyncingData {
pub is_syncing: bool, pub is_syncing: bool,
pub is_optimistic: bool, pub is_optimistic: Option<bool>,
pub head_slot: Slot, pub head_slot: Slot,
pub sync_distance: Slot, pub sync_distance: Slot,
} }