cerc-io/lighthouse
16
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Softer penalties for missing blocks (#2075)

Browse Source 
## Issue Addressed

Users are reporting errors for sending attestations to peers. If the clock sync is a little out or we receive attestations before blocks, peers are being too harshly penalized. They can get scored many times per missing block and we typically need these peers on subnets. 


## Proposed Changes

This removes the penalization for missing blocks with attestations. The penalty should be handled when #635 gets built as it will allow us to group attestations per missing block and penalize once.
This commit is contained in:
Age Manning 2020-12-10 00:40:12 +00:00
parent adbd49ddc6
commit dfb588e521
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
beacon_node/network/src/beacon_processor/worker/gossip_methods.rs
View File

@ -682,6 +682,7 @@ impl<T: BeaconChainTypes> Worker<T> {
// https://github.com/sigp/lighthouse/issues/1039 // https://github.com/sigp/lighthouse/issues/1039
// TODO: Maintain this attestation and re-process once sync completes // TODO: Maintain this attestation and re-process once sync completes
// TODO: We then score based on whether we can download the block and re-process.
debug!( debug!(
self.log, self.log,
"Attestation for unknown block"; "Attestation for unknown block";
@ -701,10 +702,6 @@ impl<T: BeaconChainTypes> Worker<T> {
"msg" => "UnknownBlockHash" "msg" => "UnknownBlockHash"
) )
}); });
// We still penalize the peer slightly. We don't want this to be a recurring
// behaviour.
self.gossip_penalize_peer(peer_id.clone(), PeerAction::HighToleranceError);
self.propagate_validation_result(message_id, peer_id, MessageAcceptance::Ignore); self.propagate_validation_result(message_id, peer_id, MessageAcceptance::Ignore);
return; return;
} }