cerc-io/lighthouse
16
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Reduce log severity for late and unrevealed blocks (#3775)

Browse Source 
## Issue Addressed

NA

## Proposed Changes

In #3725 I introduced a `CRIT` log for unrevealed payloads, against @michaelsproul's [advice](https://github.com/sigp/lighthouse/pull/3725#discussion_r1034142113). After being woken up in the middle of the night by a block that was not revealed to the BN but *was* revealed to the network, I have capitulated. This PR implements @michaelsproul's suggestion and reduces the severity to `ERRO`.

Additionally, I have dropped a `CRIT` to an `ERRO` for when a block is published late. The block in question was indeed published late on the network, however now that we have builders that can slow down block production I don't think the error is "actionable" enough to warrant a `CRIT` for the user.

## Additional Info

NA
This commit is contained in:
Paul Hauner 2022-12-10 00:45:18 +00:00
parent 979b73c9b6
commit c973bfc90c
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
beacon_node/execution_layer/src/lib.rs
View File

@ -1556,7 +1556,7 @@ impl<T: EthSpec> ExecutionLayer<T> {
&metrics::EXECUTION_LAYER_BUILDER_REVEAL_PAYLOAD_OUTCOME, &metrics::EXECUTION_LAYER_BUILDER_REVEAL_PAYLOAD_OUTCOME,
&[metrics::FAILURE], &[metrics::FAILURE],
); );
crit!( error!(
self.log(), self.log(),
"Builder failed to reveal payload"; "Builder failed to reveal payload";
"info" => "this relay failure may cause a missed proposal", "info" => "this relay failure may cause a missed proposal",

12
beacon_node/http_api/src/publish_blocks.rs
View File

@ -5,7 +5,7 @@ use beacon_chain::{
}; };
use lighthouse_network::PubsubMessage; use lighthouse_network::PubsubMessage;
use network::NetworkMessage; use network::NetworkMessage;
use slog::{crit, error, info, warn, Logger}; use slog::{error, info, warn, Logger};
use slot_clock::SlotClock; use slot_clock::SlotClock;
use std::sync::Arc; use std::sync::Arc;
use tokio::sync::mpsc::UnboundedSender; use tokio::sync::mpsc::UnboundedSender;
@ -72,10 +72,10 @@ pub async fn publish_block<T: BeaconChainTypes>(
// //
// Check to see the thresholds are non-zero to avoid logging errors with small // Check to see the thresholds are non-zero to avoid logging errors with small
// slot times (e.g., during testing) // slot times (e.g., during testing)
let crit_threshold = chain.slot_clock.unagg_attestation_production_delay(); let too_late_threshold = chain.slot_clock.unagg_attestation_production_delay();
let error_threshold = crit_threshold / 2; let delayed_threshold = too_late_threshold / 2;
if delay >= crit_threshold { if delay >= too_late_threshold {
crit!( error!(
log, log,
"Block was broadcast too late"; "Block was broadcast too late";
"msg" => "system may be overloaded, block likely to be orphaned", "msg" => "system may be overloaded, block likely to be orphaned",
@ -83,7 +83,7 @@ pub async fn publish_block<T: BeaconChainTypes>(
"slot" => block.slot(), "slot" => block.slot(),
"root" => ?root, "root" => ?root,
) )
} else if delay >= error_threshold { } else if delay >= delayed_threshold {
error!( error!(
log, log,
"Block broadcast was delayed"; "Block broadcast was delayed";