cerc-io/lighthouse
16
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Return readonly: false for local keystores (#3490)

Browse Source 
## Issue Addressed

NA

## Proposed Changes

Indicate that local keystores are `readonly: Some(false)` rather than `None` via the `/eth/v1/keystores` method on the VC API.

I'll mark this as backwards-incompat so we remember to mention it in the release notes. There aren't any type-level incompatibilities here, just a change in how Lighthouse responds to responses.

## Additional Info

- Blocked on #3464
This commit is contained in:
Paul Hauner 2022-08-24 23:35:00 +00:00
parent ebd661783e
commit c64e17bb81
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
validator_client/src/http_api/keystores.rs
View File

@ -40,7 +40,7 @@ pub fn list<T: SlotClock + 'static, E: EthSpec>(
SigningMethod::LocalKeystore { SigningMethod::LocalKeystore {
ref voting_keystore, ref voting_keystore,
.. ..
} => (voting_keystore.path(), None), } => (voting_keystore.path(), Some(false)),
SigningMethod::Web3Signer { .. } => (None, Some(true)), SigningMethod::Web3Signer { .. } => (None, Some(true)),
}); });

4
validator_client/src/http_api/tests/keystores.rs
View File

@ -399,7 +399,7 @@ fn get_web3_signer_keystores() {
.map(|local_keystore| SingleKeystoreResponse { .map(|local_keystore| SingleKeystoreResponse {
validating_pubkey: keystore_pubkey(local_keystore), validating_pubkey: keystore_pubkey(local_keystore),
derivation_path: local_keystore.path(), derivation_path: local_keystore.path(),
readonly: None, readonly: Some(false),
}) })
.chain(remote_vals.iter().map(|remote_val| SingleKeystoreResponse { .chain(remote_vals.iter().map(|remote_val| SingleKeystoreResponse {
validating_pubkey: remote_val.voting_public_key.compress(), validating_pubkey: remote_val.voting_public_key.compress(),
@ -1775,7 +1775,7 @@ fn import_same_local_and_remote_keys() {
.map(|local_keystore| SingleKeystoreResponse { .map(|local_keystore| SingleKeystoreResponse {
validating_pubkey: keystore_pubkey(local_keystore), validating_pubkey: keystore_pubkey(local_keystore),
derivation_path: local_keystore.path(), derivation_path: local_keystore.path(),
readonly: None, readonly: Some(false),
}) })
.collect::<Vec<_>>(); .collect::<Vec<_>>();
for response in expected_responses { for response in expected_responses {