cerc-io/lighthouse
10
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Increase logging channel capacity (#1570)

Browse Source 
## Issue Addressed

#1464

## Proposed Changes

Increase the slog-async log channel size from the default of 128 to 2048 to reduce the number of dropped logs. 

## Additional Info
This commit is contained in:
realbigsean 2020-08-31 02:36:19 +00:00
parent adea7992f8
commit c34e8efb12
2 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
boot_node/src/lib.rs
View File

@ -9,6 +9,8 @@ mod server;
pub use cli::cli_app; pub use cli::cli_app;
use config::BootNodeConfig; use config::BootNodeConfig;
const LOG_CHANNEL_SIZE: usize = 2048;
/// Run the bootnode given the CLI configuration. /// Run the bootnode given the CLI configuration.
pub fn run(matches: &ArgMatches<'_>, debug_level: String) { pub fn run(matches: &ArgMatches<'_>, debug_level: String) {
let debug_level = match debug_level.as_str() { let debug_level = match debug_level.as_str() {
@ -26,7 +28,9 @@ pub fn run(matches: &ArgMatches<'_>, debug_level: String) {
let decorator = slog_term::TermDecorator::new().build(); let decorator = slog_term::TermDecorator::new().build();
let decorator = logging::AlignedTermDecorator::new(decorator, logging::MAX_MESSAGE_WIDTH); let decorator = logging::AlignedTermDecorator::new(decorator, logging::MAX_MESSAGE_WIDTH);
let drain = slog_term::FullFormat::new(decorator).build().fuse(); let drain = slog_term::FullFormat::new(decorator).build().fuse();
slog_async::Async::new(drain).build() slog_async::Async::new(drain)
.chan_size(LOG_CHANNEL_SIZE)
.build()
}; };
let drain = match debug_level { let drain = match debug_level {

17
lighthouse/environment/src/lib.rs
View File

@ -29,6 +29,7 @@ mod executor;
mod metrics; mod metrics;
pub const ETH2_CONFIG_FILENAME: &str = "eth2-spec.toml"; pub const ETH2_CONFIG_FILENAME: &str = "eth2-spec.toml";
const LOG_CHANNEL_SIZE: usize = 2048;
/// Builds an `Environment`. /// Builds an `Environment`.
pub struct EnvironmentBuilder<E: EthSpec> { pub struct EnvironmentBuilder<E: EthSpec> {
@ -129,7 +130,9 @@ impl<E: EthSpec> EnvironmentBuilder<E> {
match format.to_uppercase().as_str() { match format.to_uppercase().as_str() {
"JSON" => { "JSON" => {
let drain = slog_json::Json::default(std::io::stdout()).fuse(); let drain = slog_json::Json::default(std::io::stdout()).fuse();
slog_async::Async::new(drain).build() slog_async::Async::new(drain)
.chan_size(LOG_CHANNEL_SIZE)
.build()
} }
_ => return Err("Logging format provided is not supported".to_string()), _ => return Err("Logging format provided is not supported".to_string()),
} }
@ -138,7 +141,9 @@ impl<E: EthSpec> EnvironmentBuilder<E> {
let decorator = let decorator =
logging::AlignedTermDecorator::new(decorator, logging::MAX_MESSAGE_WIDTH); logging::AlignedTermDecorator::new(decorator, logging::MAX_MESSAGE_WIDTH);
let drain = slog_term::FullFormat::new(decorator).build().fuse(); let drain = slog_term::FullFormat::new(decorator).build().fuse();
slog_async::Async::new(drain).build() slog_async::Async::new(drain)
.chan_size(LOG_CHANNEL_SIZE)
.build()
}; };
let drain = match debug_level { let drain = match debug_level {
@ -192,7 +197,9 @@ impl<E: EthSpec> EnvironmentBuilder<E> {
match format.to_uppercase().as_str() { match format.to_uppercase().as_str() {
"JSON" => { "JSON" => {
let drain = slog_json::Json::default(file).fuse(); let drain = slog_json::Json::default(file).fuse();
slog_async::Async::new(drain).build() slog_async::Async::new(drain)
.chan_size(LOG_CHANNEL_SIZE)
.build()
} }
_ => return Err("Logging format provided is not supported".to_string()), _ => return Err("Logging format provided is not supported".to_string()),
} }
@ -201,7 +208,9 @@ impl<E: EthSpec> EnvironmentBuilder<E> {
let decorator = let decorator =
logging::AlignedTermDecorator::new(decorator, logging::MAX_MESSAGE_WIDTH); logging::AlignedTermDecorator::new(decorator, logging::MAX_MESSAGE_WIDTH);
let drain = slog_term::FullFormat::new(decorator).build().fuse(); let drain = slog_term::FullFormat::new(decorator).build().fuse();
slog_async::Async::new(drain).build() slog_async::Async::new(drain)
.chan_size(LOG_CHANNEL_SIZE)
.build()
}; };
let drain = match debug_level { let drain = match debug_level {