cerc-io/lighthouse
16
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Avoid excessive logging of BN online status (#4315)

Browse Source 
## Issue Addressed

https://github.com/sigp/lighthouse/pull/4309#issuecomment-1556052261

## Proposed Changes

Log the `Connected to beacon node` message only if the node was previously offline. This avoids a regression in logging after #4295, whereby the `Connected to beacon node` message would be logged every slot.

The new reduced logging is _slightly different_ from what we had prior to my changes in #4295. The main difference is that we used to log the `Connected` message whenever a node was online and subject to a health check (for being unhealthy in some other way). I think the new behaviour is reasonable, as the `Connected` message isn't particularly helpful if the BN is unhealthy, and the specific reason for unhealthiness will be logged by the warnings for `is_compatible`/`is_synced`.
This commit is contained in:
Michael Sproul 2023-05-22 02:36:43 +00:00
parent 981c72e863
commit c27f2bf9c6
1 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
validator_client/src/beacon_node_fallback.rs
View File

@ -182,7 +182,10 @@ impl<E: EthSpec> CandidateBeaconNode<E> {
spec: &ChainSpec, spec: &ChainSpec,
log: &Logger, log: &Logger,
) -> Result<(), CandidateError> { ) -> Result<(), CandidateError> {
let new_status = if let Err(e) = self.is_online(log).await { let previous_status = self.status(RequireSynced::Yes).await;
let was_offline = matches!(previous_status, Err(CandidateError::Offline));
let new_status = if let Err(e) = self.is_online(was_offline, log).await {
Err(e) Err(e)
} else if let Err(e) = self.is_compatible(spec, log).await { } else if let Err(e) = self.is_compatible(spec, log).await {
Err(e) Err(e)
@ -202,7 +205,7 @@ impl<E: EthSpec> CandidateBeaconNode<E> {
} }
/// Checks if the node is reachable. /// Checks if the node is reachable.
async fn is_online(&self, log: &Logger) -> Result<(), CandidateError> { async fn is_online(&self, was_offline: bool, log: &Logger) -> Result<(), CandidateError> {
let result = self let result = self
.beacon_node .beacon_node
.get_node_version() .get_node_version()
@ -211,12 +214,14 @@ impl<E: EthSpec> CandidateBeaconNode<E> {
match result { match result {
Ok(version) => { Ok(version) => {
info!( if was_offline {
log, info!(
"Connected to beacon node"; log,
"version" => version, "Connected to beacon node";
"endpoint" => %self.beacon_node, "version" => version,
); "endpoint" => %self.beacon_node,
);
}
Ok(()) Ok(())
} }
Err(e) => { Err(e) => {