cerc-io/lighthouse
16
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Lower deposit finalization error to warning (#3739)

Browse Source 
## Issue Addressed

Partially addresses #3707

## Proposed Changes

Drop `ERRO` log to `WARN` until we identify the exact conditions that lead to this case.

Add a message which hopefully reassures users who only see this log once 😅 

Add the block hash to the error message in case it will prove useful in debugging the root cause.
This commit is contained in:
Michael Sproul 2022-11-21 06:29:03 +00:00
parent e3729533a1
commit b477c42748
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
beacon_node/eth1/src/service.rs
View File

@ -751,10 +751,11 @@ impl Service {
let deposit_count_to_finalize = eth1data_to_finalize.deposit_count; let deposit_count_to_finalize = eth1data_to_finalize.deposit_count;
if deposit_count_to_finalize > already_finalized { if deposit_count_to_finalize > already_finalized {
match self.finalize_deposits(eth1data_to_finalize) { match self.finalize_deposits(eth1data_to_finalize) {
Err(e) => error!( Err(e) => warn!(
self.log, self.log,
"Failed to finalize deposit cache"; "Failed to finalize deposit cache";
"error" => ?e, "error" => ?e,
"info" => "this should resolve on its own"
), ),
Ok(()) => info!( Ok(()) => info!(
self.log, self.log,
@ -814,9 +815,10 @@ impl Service {
.block_by_hash(&eth1_data.block_hash) .block_by_hash(&eth1_data.block_hash)
.cloned() .cloned()
.ok_or_else(|| { .ok_or_else(|| {
Error::FailedToFinalizeDeposit( Error::FailedToFinalizeDeposit(format!(
"Finalized block not found in block cache".to_string(), "Finalized block not found in block cache: {:?}",
) eth1_data.block_hash
))
})?; })?;
self.inner self.inner
.deposit_cache .deposit_cache