From 4a9faa3168064000d489ab115e8b921e98fe202e Mon Sep 17 00:00:00 2001 From: Feng94 <8751189+Feng94@users.noreply.github.com> Date: Sun, 27 Jan 2019 14:57:48 +1100 Subject: [PATCH] Add windows notes to readme and fix some grammar errors --- README.md | 35 ++++++++++++++++++++++++----------- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/README.md b/README.md index 9ed5acecc..0d8a32040 100644 --- a/README.md +++ b/README.md @@ -103,28 +103,41 @@ A few basic steps are needed to get set up: 1. Install [rustup](https://rustup.rs/). It's a toolchain manager for Rust (Linux | macos | Windows). For installation run the below command in your terminal ``` $ curl https://sh.rustup.rs -sSf | sh -``` - 2. To configure your current shell run: + ``` + 2. (Linux & MacOS) To configure your current shell run: ``` $ source $HOME/.cargo/env -``` - - 3. Use the command `rustup show` to get information about the Rust installation. You should see that the active toolchain is the stable version. - 4. Run `rustc --version` to check the installation and version of rust. + ``` + 3. Use the command `rustup show` to get information about the Rust installation. You should see that the + active toolchain is the stable version. + 4. Run `rustc --version` to check the installation and version of rust. - Updates can be performed using` rustup update` . - 5. Install build dependancies (Arch packages are listed here, your distribution will - likely be similar): + 5. Install build dependencies (Arch packages are listed here, your distribution will likely be similar): - `clang`: required by RocksDB. - `protobuf`: required for protobuf serialization (gRPC). - 5. Navigate to the working directory. - 6. Run the test by using command `cargo test --all` . By running, it will pass all the required test cases. If you are doing it for the first time, then you can grab a coffee meantime. Usually, it takes time to build, compile and pass all test cases. If there is no error then, it means everything is working properly and it's time to get hand's dirty. In case, if there is an error, then please raise the [issue](https://github.com/sigp/lighthouse/issues). We will help you. - 7. As an alternative to, or instead of the above step, you may also run benchmarks by using the command `cargo bench --all` + 6. Navigate to the working directory. + 7. Run the test by using command `cargo test --all`. By running, it will pass all the required test cases. + If you are doing it for the first time, then you can grab a coffee in the meantime. Usually, it takes time + to build, compile and pass all test cases. If there is no error then it means everything is working properly + and it's time to get your hands dirty. + In case, if there is an error, then please raise the [issue](https://github.com/sigp/lighthouse/issues). + We will help you. + 8. As an alternative to, or instead of the above step, you may also run benchmarks by using + the command `cargo bench --all` ##### Note: Lighthouse presently runs on Rust `stable`, however, benchmarks currently require the `nightly` version. +##### Note for Windows users: +Perl may also be required to build lighthouse. You can install [Strawberry Perl](http://strawberryperl.com/), +or alternatively use a choco install command `choco install strawberryperl`. + +Additionally, the dependency `protoc-grpcio v0.3.1` is reported to have issues compiling in Windows. You can specify +a known working version by editing version in protos/Cargo.toml's "build-dependencies" section to +`protoc-grpcio = "<=0.3.0"`. + ### Contributing **Lighthouse welcomes contributors with open-arms.**