cerc-io/lighthouse
16
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Update zeroize_derive (#2625)

Browse Source 
## Issue Addressed

NA

## Proposed Changes

As `cargo audit` astutely pointed out, the version of `zeroize_derive` were were using had a vulnerability:

```
Crate:         zeroize_derive
Version:       1.1.0
Title:         `#[zeroize(drop)]` doesn't implement `Drop` for `enum`s
Date:          2021-09-24
ID:            RUSTSEC-2021-0115
URL:           https://rustsec.org/advisories/RUSTSEC-2021-0115
Solution:      Upgrade to >=1.2.0
```

This PR updates `zeroize` and `zeroize_derive` to appease `cargo audit`.

`tiny-bip39` was also updated to allow compile.

## Additional Info

I don't believe this vulnerability actually affected the Lighthouse code-base directly. However, `tiny-bip39` may have been affected which may have resulted in some uncleaned memory in Lighthouse. Whilst this is not ideal, it's not a major issue. Zeroization is a nice-to-have since it only protects from sophisticated attacks or attackers that already have a high level of access already.
This commit is contained in:
Paul Hauner 2021-09-25 05:58:37 +00:00
parent fe52322088
commit 924a1345b1
7 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Cargo.lock generated
View File

@ -2935,6 +2935,9 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "bee0328b1209d157ef001c94dd85b4f8f64139adb0eac2659f4b08382b2f474d" checksum = "bee0328b1209d157ef001c94dd85b4f8f64139adb0eac2659f4b08382b2f474d"
dependencies = [ dependencies = [
"cfg-if 1.0.0", "cfg-if 1.0.0",
"js-sys",
"wasm-bindgen",
"web-sys",
] ]
[[package]] [[package]]
@ -6320,13 +6323,14 @@ dependencies = [
[[package]] [[package]]
name = "tiny-bip39" name = "tiny-bip39"
version = "0.8.0" version = "0.8.1"
source = "registry+https://github.com/rust-lang/crates.io-index" source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "d9e44c4759bae7f1032e286a7ef990bd9ed23fe831b7eeba0beb97484c2e59b8" checksum = "524daa5624d9d4ffb5a0625971d35205b882111daa6b6338a7a6c578a3c36928"
dependencies = [ dependencies = [
"anyhow", "anyhow",
"hmac 0.8.1", "hmac 0.8.1",
"once_cell", "once_cell",
"parking_lot",
"pbkdf2 0.4.0", "pbkdf2 0.4.0",
"rand 0.7.3", "rand 0.7.3",
"rustc-hash", "rustc-hash",
@ -7443,18 +7447,18 @@ dependencies = [
[[package]] [[package]]
name = "zeroize" name = "zeroize"
version = "1.4.1" version = "1.4.2"
source = "registry+https://github.com/rust-lang/crates.io-index" source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "377db0846015f7ae377174787dd452e1c5f5a9050bc6f954911d01f116daa0cd" checksum = "bf68b08513768deaa790264a7fac27a58cbf2705cfcdc9448362229217d7e970"
dependencies = [ dependencies = [
"zeroize_derive", "zeroize_derive",
] ]
[[package]] [[package]]
name = "zeroize_derive" name = "zeroize_derive"
version = "1.1.0" version = "1.2.0"
source = "registry+https://github.com/rust-lang/crates.io-index" source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "a2c1e130bebaeab2f23886bf9acbaca14b092408c452543c857f66399cd6dab1" checksum = "bdff2024a851a322b08f179173ae2ba620445aef1e838f0c196820eade4ae0c7"
dependencies = [ dependencies = [
"proc-macro2", "proc-macro2",
"quote", "quote",

2
common/account_utils/Cargo.toml
View File

@ -11,7 +11,7 @@ rand = "0.7.3"
eth2_wallet = { path = "../../crypto/eth2_wallet" } eth2_wallet = { path = "../../crypto/eth2_wallet" }
eth2_keystore = { path = "../../crypto/eth2_keystore" } eth2_keystore = { path = "../../crypto/eth2_keystore" }
filesystem = { path = "../filesystem" } filesystem = { path = "../filesystem" }
zeroize = { version = "1.1.1", features = ["zeroize_derive"] } zeroize = { version = "1.4.2", features = ["zeroize_derive"] }
serde = "1.0.116" serde = "1.0.116"
serde_derive = "1.0.116" serde_derive = "1.0.116"
serde_yaml = "0.8.13" serde_yaml = "0.8.13"

2
common/eth2/Cargo.toml
View File

@ -15,7 +15,7 @@ reqwest = { version = "0.11.0", features = ["json","stream"] }
eth2_libp2p = { path = "../../beacon_node/eth2_libp2p" } eth2_libp2p = { path = "../../beacon_node/eth2_libp2p" }
proto_array = { path = "../../consensus/proto_array", optional = true } proto_array = { path = "../../consensus/proto_array", optional = true }
eth2_serde_utils = "0.1.0" eth2_serde_utils = "0.1.0"
zeroize = { version = "1.1.1", features = ["zeroize_derive"] } zeroize = { version = "1.4.2", features = ["zeroize_derive"] }
eth2_keystore = { path = "../../crypto/eth2_keystore" } eth2_keystore = { path = "../../crypto/eth2_keystore" }
libsecp256k1 = "0.6.0" libsecp256k1 = "0.6.0"
ring = "0.16.19" ring = "0.16.19"

2
crypto/bls/Cargo.toml
View File

@ -16,7 +16,7 @@ hex = "0.4.2"
eth2_hashing = "0.2.0" eth2_hashing = "0.2.0"
ethereum-types = "0.11.0" ethereum-types = "0.11.0"
arbitrary = { version = "0.4.6", features = ["derive"], optional = true } arbitrary = { version = "0.4.6", features = ["derive"], optional = true }
zeroize = { version = "1.1.1", features = ["zeroize_derive"] } zeroize = { version = "1.4.2", features = ["zeroize_derive"] }
blst = "0.3.3" blst = "0.3.3"
[features] [features]

2
crypto/eth2_key_derivation/Cargo.toml
View File

@ -8,7 +8,7 @@ edition = "2018"
[dependencies] [dependencies]
sha2 = "0.9.1" sha2 = "0.9.1"
zeroize = { version = "1.1.1", features = ["zeroize_derive"] } zeroize = { version = "1.4.2", features = ["zeroize_derive"] }
num-bigint-dig = { version = "0.6.0", features = ["zeroize"] } num-bigint-dig = { version = "0.6.0", features = ["zeroize"] }
ring = "0.16.19" ring = "0.16.19"
bls = { path = "../bls" } bls = { path = "../bls" }

2
crypto/eth2_keystore/Cargo.toml
View File

@ -13,7 +13,7 @@ pbkdf2 = { version = "0.8.0", default-features = false }
scrypt = { version = "0.7.0", default-features = false } scrypt = { version = "0.7.0", default-features = false }
sha2 = "0.9.1" sha2 = "0.9.1"
uuid = { version = "0.8.1", features = ["serde", "v4"] } uuid = { version = "0.8.1", features = ["serde", "v4"] }
zeroize = { version = "1.1.1", features = ["zeroize_derive"] } zeroize = { version = "1.4.2", features = ["zeroize_derive"] }
serde = "1.0.116" serde = "1.0.116"
serde_repr = "0.1.6" serde_repr = "0.1.6"
hex = "0.4.2" hex = "0.4.2"

2
crypto/eth2_wallet/Cargo.toml
View File

@ -14,7 +14,7 @@ uuid = { version = "0.8.1", features = ["serde", "v4"] }
rand = "0.7.3" rand = "0.7.3"
eth2_keystore = { path = "../eth2_keystore" } eth2_keystore = { path = "../eth2_keystore" }
eth2_key_derivation = { path = "../eth2_key_derivation" } eth2_key_derivation = { path = "../eth2_key_derivation" }
tiny-bip39 = "0.8.0" tiny-bip39 = "0.8.1"
[dev-dependencies] [dev-dependencies]
hex = "0.4.2" hex = "0.4.2"