cerc-io/lighthouse
16
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Make garbage collection test less failure prone (#3599)

Browse Source 
## Issue Addressed

NA

## Proposed Changes

This PR attempts to fix the following spurious CI failure:

```
---- store_tests::garbage_collect_temp_states_from_failed_block stdout ----
thread 'store_tests::garbage_collect_temp_states_from_failed_block' panicked at 'disk store should initialize: DBError { message: "Error { message: \"IO error: lock /tmp/.tmp6DcBQ9/cold_db/LOCK: already held by process\" }" }', beacon_node/beacon_chain/tests/store_tests.rs:59:10
```

I believe that some async task is taking a clone of the store and holding it in some other thread for a short time. This creates a race-condition when we try to open a new instance of the store.

## Additional Info

NA
This commit is contained in:
Paul Hauner 2022-09-23 03:52:44 +00:00
parent 3a3dddc5fb
commit 9246a92d76
1 changed files with 43 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

75
beacon_node/beacon_chain/tests/store_tests.rs
View File

@ -26,6 +26,7 @@ use store::{
HotColdDB, LevelDB, StoreConfig, HotColdDB, LevelDB, StoreConfig,
}; };
use tempfile::{tempdir, TempDir}; use tempfile::{tempdir, TempDir};
use tokio::time::sleep;
use tree_hash::TreeHash; use tree_hash::TreeHash;
use types::test_utils::{SeedableRng, XorShiftRng}; use types::test_utils::{SeedableRng, XorShiftRng};
use types::*; use types::*;
@ -1985,45 +1986,55 @@ async fn pruning_test(
check_no_blocks_exist(&harness, stray_blocks.values()); check_no_blocks_exist(&harness, stray_blocks.values());
} }
#[test] #[tokio::test]
fn garbage_collect_temp_states_from_failed_block() { async fn garbage_collect_temp_states_from_failed_block() {
let db_path = tempdir().unwrap(); let db_path = tempdir().unwrap();
let store = get_store(&db_path);
let harness = get_harness(store.clone(), LOW_VALIDATOR_COUNT);
// Use a `block_on_dangerous` rather than an async test to stop spawned processes from holding // Wrap these functions to ensure the variables are dropped before we try to open another
// a reference to the store. // instance of the store.
harness.chain.task_executor.clone().block_on_dangerous( let mut store = {
async move { let store = get_store(&db_path);
let slots_per_epoch = E::slots_per_epoch(); let harness = get_harness(store.clone(), LOW_VALIDATOR_COUNT);
let genesis_state = harness.get_current_state(); let slots_per_epoch = E::slots_per_epoch();
let block_slot = Slot::new(2 * slots_per_epoch);
let (signed_block, state) = harness.make_block(genesis_state, block_slot).await;
let (mut block, _) = signed_block.deconstruct(); let genesis_state = harness.get_current_state();
let block_slot = Slot::new(2 * slots_per_epoch);
let (signed_block, state) = harness.make_block(genesis_state, block_slot).await;
// Mutate the block to make it invalid, and re-sign it. let (mut block, _) = signed_block.deconstruct();
*block.state_root_mut() = Hash256::repeat_byte(0xff);
let proposer_index = block.proposer_index() as usize;
let block = block.sign(
&harness.validator_keypairs[proposer_index].sk,
&state.fork(),
state.genesis_validators_root(),
&harness.spec,
);
// The block should be rejected, but should store a bunch of temporary states. // Mutate the block to make it invalid, and re-sign it.
harness.set_current_slot(block_slot); *block.state_root_mut() = Hash256::repeat_byte(0xff);
harness.process_block_result(block).await.unwrap_err(); let proposer_index = block.proposer_index() as usize;
let block = block.sign(
&harness.validator_keypairs[proposer_index].sk,
&state.fork(),
state.genesis_validators_root(),
&harness.spec,
);
assert_eq!( // The block should be rejected, but should store a bunch of temporary states.
store.iter_temporary_state_roots().count(), harness.set_current_slot(block_slot);
block_slot.as_usize() - 1 harness.process_block_result(block).await.unwrap_err();
);
}, assert_eq!(
"test", store.iter_temporary_state_roots().count(),
); block_slot.as_usize() - 1
);
store
};
// Wait until all the references to the store have been dropped, this helps ensure we can
// re-open the store later.
loop {
store = if let Err(store_arc) = Arc::try_unwrap(store) {
sleep(Duration::from_millis(500)).await;
store_arc
} else {
break;
}
}
// On startup, the store should garbage collect all the temporary states. // On startup, the store should garbage collect all the temporary states.
let store = get_store(&db_path); let store = get_store(&db_path);