cerc-io/lighthouse
16
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Prevent duplicate gossipsub loops/message amplification (#832)

Browse Source 
* Increase gossipsub duplicate cache

* Hashes of messages are now stored in LRUCache
This commit is contained in:
Age Manning 2020-01-31 18:56:49 +11:00 committed by GitHub
parent b771bbb60c
commit 8923f84af9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
beacon_node/eth2-libp2p/src/behaviour.rs
View File

@ -46,7 +46,7 @@ pub struct Behaviour<TSubstream: AsyncRead + AsyncWrite> {
/// A cache of recently seen gossip messages. This is used to filter out any possible /// A cache of recently seen gossip messages. This is used to filter out any possible
/// duplicates that may still be seen over gossipsub. /// duplicates that may still be seen over gossipsub.
#[behaviour(ignore)] #[behaviour(ignore)]
seen_gossip_messages: LruCache<PubsubMessage, ()>, seen_gossip_messages: LruCache<MessageId, ()>,
/// Logger for behaviour actions. /// Logger for behaviour actions.
#[behaviour(ignore)] #[behaviour(ignore)]
log: slog::Logger, log: slog::Logger,
@ -79,7 +79,7 @@ impl<TSubstream: AsyncRead + AsyncWrite> Behaviour<TSubstream> {
discovery: Discovery::new(local_key, net_conf, log)?, discovery: Discovery::new(local_key, net_conf, log)?,
ping: Ping::new(ping_config), ping: Ping::new(ping_config),
identify, identify,
seen_gossip_messages: LruCache::new(256), seen_gossip_messages: LruCache::new(100_000),
events: Vec::new(), events: Vec::new(),
log: behaviour_log, log: behaviour_log,
}) })
@ -105,7 +105,7 @@ impl<TSubstream: AsyncRead + AsyncWrite> NetworkBehaviourEventProcess<GossipsubE
// Note: We are keeping track here of the peer that sent us the message, not the // Note: We are keeping track here of the peer that sent us the message, not the
// peer that originally published the message. // peer that originally published the message.
if self.seen_gossip_messages.put(msg.clone(), ()).is_none() { if self.seen_gossip_messages.put(id.clone(), ()).is_none() {
// if this message isn't a duplicate, notify the network // if this message isn't a duplicate, notify the network
self.events.push(BehaviourEvent::GossipMessage { self.events.push(BehaviourEvent::GossipMessage {
id, id,