cerc-io/lighthouse
16
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

fix(validator_client): return http 404 rather than 405 in http api (#4758)

Browse Source 
## Issue Addressed
- Close #4596 

## Proposed Changes
- Add `Filter::recover` to handle rejections specifically as 404 NOT FOUND

Please list or describe the changes introduced by this PR.

## Additional Info

Similar to PR #3836
This commit is contained in:
duguorong009 2023-10-04 00:43:29 +00:00
parent ba8bcf4bd3
commit 7d537214b7
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
validator_client/src/http_api/mod.rs
View File

@ -1176,7 +1176,8 @@ pub fn serve<T: 'static + SlotClock + Clone, E: EthSpec>(
.or(get_fee_recipient) .or(get_fee_recipient)
.or(get_gas_limit) .or(get_gas_limit)
.or(get_std_keystores) .or(get_std_keystores)
.or(get_std_remotekeys), .or(get_std_remotekeys)
.recover(warp_utils::reject::handle_rejection),
) )
.or(warp::post().and( .or(warp::post().and(
post_validators post_validators
@ -1187,15 +1188,18 @@ pub fn serve<T: 'static + SlotClock + Clone, E: EthSpec>(
.or(post_fee_recipient) .or(post_fee_recipient)
.or(post_gas_limit) .or(post_gas_limit)
.or(post_std_keystores) .or(post_std_keystores)
.or(post_std_remotekeys), .or(post_std_remotekeys)
.recover(warp_utils::reject::handle_rejection),
)) ))
.or(warp::patch().and(patch_validators)) .or(warp::patch()
.and(patch_validators.recover(warp_utils::reject::handle_rejection)))
.or(warp::delete().and( .or(warp::delete().and(
delete_lighthouse_keystores delete_lighthouse_keystores
.or(delete_fee_recipient) .or(delete_fee_recipient)
.or(delete_gas_limit) .or(delete_gas_limit)
.or(delete_std_keystores) .or(delete_std_keystores)
.or(delete_std_remotekeys), .or(delete_std_remotekeys)
.recover(warp_utils::reject::handle_rejection),
)), )),
) )
// The auth route and logs are the only routes that are allowed to be accessed without the API token. // The auth route and logs are the only routes that are allowed to be accessed without the API token.