cerc-io/lighthouse
16
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Use unique arg names for eth1-sim (#4463)

Browse Source 
## Issue Addressed

When trying to run `eth1-sim` locally, the simulator doesn't start for me, and panicked due to duplicate arg names for `proposer-nodes` (using same arg names as `nodes`). Not sure why this isn't failing on CI but failing on mine 🤔 

```
thread 'main' panicked at 'Argument short must be unique
thread 'main' panicked at 'Argument long must be unique
```
This commit is contained in:
Jimmy Chen 2023-07-17 00:14:13 +00:00
parent 6c375205fb
commit 5cd738c882
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
testing/simulator/src/cli.rs
View File

@ -25,8 +25,8 @@ pub fn cli_app<'a, 'b>() -> App<'a, 'b> {
.default_value("4") .default_value("4")
.help("Number of beacon nodes")) .help("Number of beacon nodes"))
.arg(Arg::with_name("proposer-nodes") .arg(Arg::with_name("proposer-nodes")
.short("n") .short("p")
.long("nodes") .long("proposer_nodes")
.takes_value(true) .takes_value(true)
.default_value("2") .default_value("2")
.help("Number of proposer-only beacon nodes")) .help("Number of proposer-only beacon nodes"))
@ -64,8 +64,8 @@ pub fn cli_app<'a, 'b>() -> App<'a, 'b> {
.default_value("4") .default_value("4")
.help("Number of beacon nodes")) .help("Number of beacon nodes"))
.arg(Arg::with_name("proposer-nodes") .arg(Arg::with_name("proposer-nodes")
.short("n") .short("p")
.long("nodes") .long("proposer_nodes")
.takes_value(true) .takes_value(true)
.default_value("2") .default_value("2")
.help("Number of proposer-only beacon nodes")) .help("Number of proposer-only beacon nodes"))