cerc-io/lighthouse
16
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Modify some Capella comments (#4015)

Browse Source 
* Modify comment to only include 4844

Capella only modifies per epoch processing by adding
`process_historical_summaries_update`, which does not change the realization of
justification or finality.

Whilst 4844 does not currently modify realization, the spec is not yet final
enough to say that it never will.

* Clarify address change verification comment

The verification of the address change doesn't really have anything to do with
the current epoch. I think this was just a copy-paste from a function like
`verify_exit`.
This commit is contained in:
Paul Hauner 2023-02-21 18:03:42 +11:00 committed by GitHub
parent 1bce7a02c8
commit 40669da486
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
consensus/fork_choice/src/fork_choice.rs
View File

@ -857,8 +857,8 @@ where
(parent_justified, parent_finalized) (parent_justified, parent_finalized)
} else { } else {
let justification_and_finalization_state = match block { let justification_and_finalization_state = match block {
// FIXME: verify this is correct for Capella/Eip4844 because // TODO(eip4844): Ensure that the final specification
// epoch processing changes in Capella.. // does not substantially modify per epoch processing.
BeaconBlockRef::Eip4844(_) BeaconBlockRef::Eip4844(_)
| BeaconBlockRef::Capella(_) | BeaconBlockRef::Capella(_)
| BeaconBlockRef::Merge(_) | BeaconBlockRef::Merge(_)

4
consensus/state_processing/src/per_block_processing/verify_bls_to_execution_change.rs
View File

@ -10,8 +10,8 @@ fn error(reason: Invalid) -> BlockOperationError<Invalid> {
BlockOperationError::invalid(reason) BlockOperationError::invalid(reason)
} }
/// Indicates if a `BlsToExecutionChange` is valid to be included in a block in the current epoch of the given /// Indicates if a `BlsToExecutionChange` is valid to be included in a block,
/// state. /// where the block is being applied to the given `state`.
/// ///
/// Returns `Ok(())` if the `SignedBlsToExecutionChange` is valid, otherwise indicates the reason for invalidity. /// Returns `Ok(())` if the `SignedBlsToExecutionChange` is valid, otherwise indicates the reason for invalidity.
pub fn verify_bls_to_execution_change<T: EthSpec>( pub fn verify_bls_to_execution_change<T: EthSpec>(