cerc-io/lighthouse
10
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Add metrics for individual async tasks (#2735)

Browse Source 
I have been in the process of debugging libp2p tasks as there is something locking our executor. 

This addition adds a metric allowing us to track all tasks within lighthouse allowing us to identify various sections of Lighthouse code that may be taking longer than normal to process.
This commit is contained in:
Age Manning 2021-10-25 05:18:49 +00:00
parent bf1667a904
commit 3a51f829d5
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common/task_executor/src/lib.rs
View File

@ -96,6 +96,7 @@ impl TaskExecutor {
if let Some(runtime) = self.runtime.upgrade() { if let Some(runtime) = self.runtime.upgrade() {
runtime.spawn(async move { runtime.spawn(async move {
let timer = metrics::start_timer_vec(&metrics::TASKS_HISTOGRAM, &[name]);
if let Err(join_error) = task_handle.await { if let Err(join_error) = task_handle.await {
if let Ok(panic) = join_error.try_into_panic() { if let Ok(panic) = join_error.try_into_panic() {
let message = panic.downcast_ref::<&str>().unwrap_or(&"<none>"); let message = panic.downcast_ref::<&str>().unwrap_or(&"<none>");
@ -112,6 +113,7 @@ impl TaskExecutor {
.try_send(ShutdownReason::Failure("Panic (fatal error)")); .try_send(ShutdownReason::Failure("Panic (fatal error)"));
} }
} }
drop(timer);
}); });
} else { } else {
debug!( debug!(

5
common/task_executor/src/metrics.rs
View File

@ -18,4 +18,9 @@ lazy_static! {
"Time taken by blocking tasks", "Time taken by blocking tasks",
&["blocking_task_hist"] &["blocking_task_hist"]
); );
pub static ref TASKS_HISTOGRAM: Result<HistogramVec> = try_create_histogram_vec(
"async_tasks_time_histogram",
"Time taken by async tasks",
&["async_task_hist"]
);
} }