cerc-io/lighthouse
16
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

router: drop requests from peers that have dc'd (#1919)

Browse Source 
## Issue Addressed

A peer might send a lot of requests that comply to the rate limit and the disconnect, this humongous pr makes sure we don't process them if the peer is not connected
This commit is contained in:
divma 2020-11-17 02:06:21 +00:00
parent 280334b1b0
commit 398919b5d4
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
beacon_node/network/src/router/mod.rs
View File

@ -26,6 +26,8 @@ use types::EthSpec;
/// passing them to the internal message processor. The message processor spawns a syncing thread /// passing them to the internal message processor. The message processor spawns a syncing thread
/// which manages which blocks need to be requested and processed. /// which manages which blocks need to be requested and processed.
pub struct Router<T: BeaconChainTypes> { pub struct Router<T: BeaconChainTypes> {
/// Access to the peer db.
network_globals: Arc<NetworkGlobals<T::EthSpec>>,
/// Processes validated and decoded messages from the network. Has direct access to the /// Processes validated and decoded messages from the network. Has direct access to the
/// sync manager. /// sync manager.
processor: Processor<T>, processor: Processor<T>,
@ -83,13 +85,14 @@ impl<T: BeaconChainTypes> Router<T> {
let processor = Processor::new( let processor = Processor::new(
executor.clone(), executor.clone(),
beacon_chain, beacon_chain,
network_globals, network_globals.clone(),
network_send, network_send,
&log, &log,
); );
// generate the Message handler // generate the Message handler
let mut handler = Router { let mut handler = Router {
network_globals,
processor, processor,
log: message_handler_log, log: message_handler_log,
}; };
@ -150,6 +153,10 @@ impl<T: BeaconChainTypes> Router<T> {
/// A new RPC request has been received from the network. /// A new RPC request has been received from the network.
fn handle_rpc_request(&mut self, peer_id: PeerId, id: PeerRequestId, request: Request) { fn handle_rpc_request(&mut self, peer_id: PeerId, id: PeerRequestId, request: Request) {
if !self.network_globals.peers.read().is_connected(&peer_id) {
debug!(self.log, "Dropping request of disconnected peer"; "peer_id" => %peer_id, "request" => ?request);
return;
}
match request { match request {
Request::Status(status_message) => { Request::Status(status_message) => {
self.processor self.processor