cerc-io/lighthouse
16
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

fixup! Complete making blocks and blobs db atomic

Browse Source
This commit is contained in:
Emilia Hane 2023-02-06 10:18:06 +01:00
parent ca934b7cb5
commit 38fe2dce3f
No known key found for this signature in database
GPG Key ID: E73394F9C09206FA
1 changed files with 11 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
beacon_node/store/src/hot_cold_store.rs
View File

@ -123,6 +123,7 @@ pub enum HotColdDBError {
request_slot: Option<Slot>, request_slot: Option<Slot>,
state_root: Hash256, state_root: Hash256,
}, },
Rollback,
} }
impl<E: EthSpec> HotColdDB<E, MemoryStore<E>, MemoryStore<E>> { impl<E: EthSpec> HotColdDB<E, MemoryStore<E>, MemoryStore<E>> {
@ -906,22 +907,17 @@ impl<E: EthSpec, Hot: ItemStore<E>, Cold: ItemStore<E>> HotColdDB<E, Hot, Cold>
}; };
// Rollback on failure // Rollback on failure
if let Err(e) = tx_res { if let Err(e) = tx_res {
let mut rollback_blob_ops: Vec<StoreOp<E>> = Vec::with_capacity(blob_cache_ops.len()); for op in blob_cache_ops.iter_mut() {
for blob_op in blob_cache_ops { let reverse_op = match op {
match blob_op { StoreOp::PutBlobs(block_root, _) => StoreOp::DeleteBlobs(block_root),
StoreOp::PutBlobs(block_root, _) => { StoreOp::DeleteBlobs(_) => match blobs_to_delete.pop() {
rollback_blob_ops.push(StoreOp::DeleteBlobs(block_root)); Some(blobs) => StoreOp::PutBlobs(blobs.beacon_block_root, Arc::new(blobs)),
} None => return Err(HotColdDBError::Rollback.into()),
StoreOp::DeleteBlobs(_) => { },
if let Some(blobs) = blobs_to_delete.pop() { _ => return Err(HotColdDBError::Rollback.into()),
rollback_blob_ops };
.push(StoreOp::PutBlobs(blobs.beacon_block_root, Arc::new(blobs)));
}
}
_ => (),
}
} }
blobs_db.do_atomically(self.convert_to_kv_batch(rollback_blob_ops)?)?; blobs_db.do_atomically(self.convert_to_kv_batch(blob_cache_ops)?)?;
return Err(e); return Err(e);
} }