cerc-io/lighthouse
10
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Remove default beacon node value from clap (#2121)

Browse Source 
## Issue Addressed

Fixes #2118 

## Proposed Changes

Removes the default value in clap for `--beacon-nodes`. 
This was causing issues with cli picking `--beacon-nodes` default even when not specified and overriding `--beacon-node`.
Seems like it was more evident with docker setups because it doesn't use the default `http://localhost:5052` option.

Edit: we already set the default to `http://localhost:5052` here so this shouldn't break any existing setups.
9ed65a64f8/validator_client/src/config.rs (L58) 

## Additional info
Tested this with docker-compose and binaries. Works as expected in both cases.
This commit is contained in:
Pawan Dhananjay 2020-12-28 08:23:59 +00:00
parent 43ac3f7209
commit 32a60578fe
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
validator_client/src/cli.rs
View File

@ -1,4 +1,3 @@
use crate::config::DEFAULT_BEACON_NODE;
use clap::{App, Arg}; use clap::{App, Arg};
pub fn cli_app<'a, 'b>() -> App<'a, 'b> { pub fn cli_app<'a, 'b>() -> App<'a, 'b> {
@ -22,8 +21,9 @@ pub fn cli_app<'a, 'b>() -> App<'a, 'b> {
Arg::with_name("beacon-nodes") Arg::with_name("beacon-nodes")
.long("beacon-nodes") .long("beacon-nodes")
.value_name("NETWORK_ADDRESSES") .value_name("NETWORK_ADDRESSES")
.help("Comma-separated addresses to one or more beacon node HTTP APIs") .help("Comma-separated addresses to one or more beacon node HTTP APIs. \
.default_value(&DEFAULT_BEACON_NODE) Default is http://localhost:5052."
)
.takes_value(true), .takes_value(true),
) )
// This argument is deprecated, use `--beacon-nodes` instead. // This argument is deprecated, use `--beacon-nodes` instead.