cerc-io/lighthouse
10
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Log a debug message when a request fails for a beacon node candidate (#4036)

Browse Source 
## Issue Addressed
#3985

## Proposed Changes

Log a debug message when a BN candidate returns an error.

`Mar 01 16:40:24.011 DEBG Request to beacon node failed           error: ServerMessage(ErrorMessage { code: 503, message: "SERVICE_UNAVAILABLE: beacon node is syncing: head slot is 8416, current slot is 5098402", stacktraces: [] }), node: http://localhost:5052/`
This commit is contained in:
Atanas Minkov 2023-03-02 05:26:14 +00:00
parent 5b18fd92cb
commit 2b6348781a
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
validator_client/src/beacon_node_fallback.rs
View File

@ -7,7 +7,7 @@ use crate::http_metrics::metrics::{inc_counter_vec, ENDPOINT_ERRORS, ENDPOINT_RE
use environment::RuntimeContext; use environment::RuntimeContext;
use eth2::BeaconNodeHttpClient; use eth2::BeaconNodeHttpClient;
use futures::future; use futures::future;
use slog::{error, info, warn, Logger}; use slog::{debug, error, info, warn, Logger};
use slot_clock::SlotClock; use slot_clock::SlotClock;
use std::fmt; use std::fmt;
use std::fmt::Debug; use std::fmt::Debug;
@ -409,10 +409,12 @@ impl<T: SlotClock, E: EthSpec> BeaconNodeFallback<T, E> {
where where
F: Fn(&'a BeaconNodeHttpClient) -> R, F: Fn(&'a BeaconNodeHttpClient) -> R,
R: Future<Output = Result<O, Err>>, R: Future<Output = Result<O, Err>>,
Err: Debug,
{ {
let mut errors = vec![]; let mut errors = vec![];
let mut to_retry = vec![]; let mut to_retry = vec![];
let mut retry_unsynced = vec![]; let mut retry_unsynced = vec![];
let log = &self.log.clone();
// Run `func` using a `candidate`, returning the value or capturing errors. // Run `func` using a `candidate`, returning the value or capturing errors.
// //
@ -427,6 +429,12 @@ impl<T: SlotClock, E: EthSpec> BeaconNodeFallback<T, E> {
match func(&$candidate.beacon_node).await { match func(&$candidate.beacon_node).await {
Ok(val) => return Ok(val), Ok(val) => return Ok(val),
Err(e) => { Err(e) => {
debug!(
log,
"Request to beacon node failed";
"node" => $candidate.beacon_node.to_string(),
"error" => ?e,
);
// If we have an error on this function, make the client as not-ready. // If we have an error on this function, make the client as not-ready.
// //
// There exists a race condition where the candidate may have been marked // There exists a race condition where the candidate may have been marked
@ -626,6 +634,7 @@ impl<T: SlotClock, E: EthSpec> BeaconNodeFallback<T, E> {
where where
F: Fn(&'a BeaconNodeHttpClient) -> R, F: Fn(&'a BeaconNodeHttpClient) -> R,
R: Future<Output = Result<(), Err>>, R: Future<Output = Result<(), Err>>,
Err: Debug,
{ {
if self.disable_run_on_all { if self.disable_run_on_all {
self.first_success(require_synced, offline_on_failure, func) self.first_success(require_synced, offline_on_failure, func)