cerc-io/lighthouse
10
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix name collision in script (#2678)

Browse Source 
## Issue Addressed

N/A

## Proposed Changes

We set a `$TAG` env variable in the github actions workflow, and then re-use this name in the `publish.sh` script. It makes this check `if [[ -z "$TAG" ]]` return true, when it should return false on the first time it's hit.

## Additional Info

N/A


Co-authored-by: realbigsean <seananderson33@gmail.com>
This commit is contained in:
realbigsean 2021-10-05 22:54:11 +00:00
parent 7c88f582d9
commit 02a646a27d
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
scripts/ci/publish.sh
View File

@ -5,7 +5,7 @@
set -e set -e
USAGE="Publish a new release of a lighthouse crate USAGE="Publish a new release of a lighthouse crate
USAGE: USAGE:
$(basename "$0") [OPTIONS] [CRATE_PATH] [CRATE] [TAG] $(basename "$0") [OPTIONS] [CRATE_PATH] [CRATE] [TAG_NAME]
OPTIONS: OPTIONS:
-v, --verbose Use verbose Cargo output -v, --verbose Use verbose Cargo output
-d, --dry-run Perform a dry run (do not publish the release) -d, --dry-run Perform a dry run (do not publish the release)
@ -72,9 +72,9 @@ case "$1" in
CRATE_PATH="$1" CRATE_PATH="$1"
elif [ -z "$CRATE" ]; then elif [ -z "$CRATE" ]; then
CRATE="$1" CRATE="$1"
elif [ -z "$TAG" ]; then elif [ -z "$TAG_NAME" ]; then
TAG="$1" TAG_NAME="$1"
VERSION=$(sed -e 's#.*-v\([0-9]\)#\1#' <<< "$TAG") VERSION=$(sed -e 's#.*-v\([0-9]\)#\1#' <<< "$TAG_NAME")
else else
echo "unknown positional argument \"$1\"" echo "unknown positional argument \"$1\""
echo "$USAGE" echo "$USAGE"