ccc6f5b53d
* Use effectiveGasPrice in ante handler for dynamic fee tx Closes: #814 Solution: - use effectiveGasPrice when check minimal-gas-prices, and deduct fee in ante handler - implement an EthMempoolFeeDecorator * add effectiveGasPrice to tx receipt * changelog * fix unit test * fix comments * add comments * Apply suggestions from code review Co-authored-by: Thomas Nguy <81727899+thomas-nguy@users.noreply.github.com> * review suggestions Co-authored-by: Thomas Nguy <81727899+thomas-nguy@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
109 lines
3.1 KiB
Go
109 lines
3.1 KiB
Go
package keeper
|
|
|
|
import (
|
|
"math/big"
|
|
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
|
|
authante "github.com/cosmos/cosmos-sdk/x/auth/ante"
|
|
|
|
evmtypes "github.com/tharsis/ethermint/x/evm/types"
|
|
|
|
"github.com/ethereum/go-ethereum/core"
|
|
ethtypes "github.com/ethereum/go-ethereum/core/types"
|
|
)
|
|
|
|
// DeductTxCostsFromUserBalance it calculates the tx costs and deducts the fees
|
|
func (k Keeper) DeductTxCostsFromUserBalance(
|
|
ctx sdk.Context,
|
|
msgEthTx evmtypes.MsgEthereumTx,
|
|
txData evmtypes.TxData,
|
|
denom string,
|
|
homestead, istanbul, london bool,
|
|
) (sdk.Coins, error) {
|
|
isContractCreation := txData.GetTo() == nil
|
|
|
|
// fetch sender account from signature
|
|
signerAcc, err := authante.GetSignerAcc(ctx, k.accountKeeper, msgEthTx.GetFrom())
|
|
if err != nil {
|
|
return nil, sdkerrors.Wrapf(err, "account not found for sender %s", msgEthTx.From)
|
|
}
|
|
|
|
gasLimit := txData.GetGas()
|
|
|
|
var accessList ethtypes.AccessList
|
|
if txData.GetAccessList() != nil {
|
|
accessList = txData.GetAccessList()
|
|
}
|
|
|
|
intrinsicGas, err := core.IntrinsicGas(txData.GetData(), accessList, isContractCreation, homestead, istanbul)
|
|
if err != nil {
|
|
return nil, sdkerrors.Wrapf(
|
|
err,
|
|
"failed to retrieve intrinsic gas, contract creation = %t; homestead = %t, istanbul = %t",
|
|
isContractCreation, homestead, istanbul,
|
|
)
|
|
}
|
|
|
|
// intrinsic gas verification during CheckTx
|
|
if ctx.IsCheckTx() && gasLimit < intrinsicGas {
|
|
return nil, sdkerrors.Wrapf(
|
|
sdkerrors.ErrOutOfGas,
|
|
"gas limit too low: %d (gas limit) < %d (intrinsic gas)", gasLimit, intrinsicGas,
|
|
)
|
|
}
|
|
|
|
var feeAmt *big.Int
|
|
|
|
feeMktParams := k.feeMarketKeeper.GetParams(ctx)
|
|
if london && !feeMktParams.NoBaseFee && txData.TxType() == ethtypes.DynamicFeeTxType {
|
|
baseFee := k.feeMarketKeeper.GetBaseFee(ctx)
|
|
if txData.GetGasFeeCap().Cmp(baseFee) < 0 {
|
|
return nil, sdkerrors.Wrapf(sdkerrors.ErrInsufficientFee, "the tx gasfeecap is lower than the tx baseFee: %s (gasfeecap), %s (basefee) ", txData.GetGasFeeCap(), baseFee)
|
|
}
|
|
feeAmt = txData.EffectiveFee(baseFee)
|
|
} else {
|
|
feeAmt = txData.Fee()
|
|
}
|
|
|
|
fees := sdk.Coins{sdk.NewCoin(denom, sdk.NewIntFromBigInt(feeAmt))}
|
|
|
|
// deduct the full gas cost from the user balance
|
|
if err := authante.DeductFees(k.bankKeeper, ctx, signerAcc, fees); err != nil {
|
|
return nil, sdkerrors.Wrapf(
|
|
err,
|
|
"failed to deduct full gas cost %s from the user %s balance",
|
|
fees, msgEthTx.From,
|
|
)
|
|
}
|
|
return fees, nil
|
|
}
|
|
|
|
// CheckSenderBalance validates that the tx cost value is positive and that the
|
|
// sender has enough funds to pay for the fees and value of the transaction.
|
|
func CheckSenderBalance(
|
|
ctx sdk.Context,
|
|
bankKeeper evmtypes.BankKeeper,
|
|
sender sdk.AccAddress,
|
|
txData evmtypes.TxData,
|
|
denom string,
|
|
) error {
|
|
balance := bankKeeper.GetBalance(ctx, sender, denom)
|
|
cost := txData.Cost()
|
|
|
|
if cost.Sign() < 0 {
|
|
return sdkerrors.Wrapf(
|
|
sdkerrors.ErrInvalidCoins,
|
|
"tx cost (%s%s) is negative and invalid", cost, denom,
|
|
)
|
|
}
|
|
|
|
if balance.IsNegative() || balance.Amount.BigInt().Cmp(cost) < 0 {
|
|
return sdkerrors.Wrapf(
|
|
sdkerrors.ErrInsufficientFunds,
|
|
"sender balance < tx cost (%s < %s%s)", balance, txData.Cost(), denom,
|
|
)
|
|
}
|
|
return nil
|
|
}
|