8333765b27
* x/evm/keeper: save 24B with Go in-condition variable idiom The prior code doubly invoked (*ethereum/go-ethereum/core/types.Transaction).To() which is quite expensive, and firstly copies 20 bytes each time, then that gets rounded up to the proper size class/pointer alignment so on 64-bit machines 20B -> 24B. Isolating a benchmark for this code per issue #826 shows this saves quite a bit of bytes and some nano seconds which all count up towards the transactions per seconds being processed: ```shell $ benchstat before.txt after.txt name old time/op new time/op delta CopyAddr-8 38.4ns ± 3% 19.3ns ± 3% -49.66% (p=0.000 n=10+10) name old alloc/op new alloc/op delta CopyAddr-8 48.0B ± 0% 24.0B ± 0% -50.00% (p=0.000 n=10+10) name old allocs/op new allocs/op delta CopyAddr-8 2.00 ± 0% 1.00 ± 0% -50.00% (p=0.000 n=10+10) ``` Fixes #826 * changelog * lint * Revert stray changes that were used in testing * rm log Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>
84 lines
2.4 KiB
Go
84 lines
2.4 KiB
Go
package keeper
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
|
|
tmbytes "github.com/tendermint/tendermint/libs/bytes"
|
|
tmtypes "github.com/tendermint/tendermint/types"
|
|
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
|
|
|
|
"github.com/tharsis/ethermint/x/evm/types"
|
|
)
|
|
|
|
var _ types.MsgServer = &Keeper{}
|
|
|
|
// EthereumTx implements the gRPC MsgServer interface. It receives a transaction which is then
|
|
// executed (i.e applied) against the go-ethereum EVM. The provided SDK Context is set to the Keeper
|
|
// so that it can implements and call the StateDB methods without receiving it as a function
|
|
// parameter.
|
|
func (k *Keeper) EthereumTx(goCtx context.Context, msg *types.MsgEthereumTx) (*types.MsgEthereumTxResponse, error) {
|
|
ctx := sdk.UnwrapSDKContext(goCtx)
|
|
k.WithContext(ctx)
|
|
|
|
sender := msg.From
|
|
tx := msg.AsTransaction()
|
|
|
|
response, err := k.ApplyTransaction(tx)
|
|
if err != nil {
|
|
return nil, sdkerrors.Wrap(err, "failed to apply transaction")
|
|
}
|
|
|
|
attrs := []sdk.Attribute{
|
|
sdk.NewAttribute(sdk.AttributeKeyAmount, tx.Value().String()),
|
|
// add event for ethereum transaction hash format
|
|
sdk.NewAttribute(types.AttributeKeyEthereumTxHash, response.Hash),
|
|
}
|
|
|
|
if len(ctx.TxBytes()) > 0 {
|
|
// add event for tendermint transaction hash format
|
|
hash := tmbytes.HexBytes(tmtypes.Tx(ctx.TxBytes()).Hash())
|
|
attrs = append(attrs, sdk.NewAttribute(types.AttributeKeyTxHash, hash.String()))
|
|
}
|
|
|
|
if to := tx.To(); to != nil {
|
|
attrs = append(attrs, sdk.NewAttribute(types.AttributeKeyRecipient, to.Hex()))
|
|
}
|
|
|
|
if response.Failed() {
|
|
attrs = append(attrs, sdk.NewAttribute(types.AttributeKeyEthereumTxFailed, response.VmError))
|
|
}
|
|
|
|
txLogAttrs := make([]sdk.Attribute, 0)
|
|
for _, log := range response.Logs {
|
|
value, err := json.Marshal(log)
|
|
if err != nil {
|
|
return nil, sdkerrors.Wrap(err, "failed to encode log")
|
|
}
|
|
txLogAttrs = append(txLogAttrs, sdk.NewAttribute(types.AttributeKeyTxLog, string(value)))
|
|
}
|
|
|
|
// emit events
|
|
ctx.EventManager().EmitEvents(sdk.Events{
|
|
sdk.NewEvent(
|
|
types.EventTypeEthereumTx,
|
|
attrs...,
|
|
),
|
|
sdk.NewEvent(
|
|
types.EventTypeTxLog,
|
|
txLogAttrs...,
|
|
),
|
|
sdk.NewEvent(
|
|
sdk.EventTypeMessage,
|
|
sdk.NewAttribute(sdk.AttributeKeyModule, types.AttributeValueCategory),
|
|
sdk.NewAttribute(sdk.AttributeKeySender, sender),
|
|
sdk.NewAttribute(types.AttributeKeyTxType, fmt.Sprintf("%d", tx.Type())),
|
|
),
|
|
})
|
|
|
|
return response, nil
|
|
}
|