cerc-io/laconicd
11
0
Fork 1
Code Issues 2 Pull Requests 2 Actions Packages Projects Releases 14 Wiki Activity

Unset home and keyring dir from depinject client config #35

Merged
nabarun merged 1 commits from pm-handle-config into main 2024-07-16 03:50:09 +00:00
Conversation 0 Commits 1 Files Changed 1
+6 -3
prathamesh commented 2024-07-15 11:36:34 +00:00
Member
Copy Link
Copy Source

Part of #33
Follows PR #34

  • With earlier workaround in root cmd (not passing DefaultNodeHome to depinject), it created a config/client.toml wherever the laconicd CLI was being run
  • Unset clientCtx.HomeDir and clientCtx.KeyringDir while providing client context to depinject instead to prevent this and still handle the --home flag precedence issue
    • When using default home directory, all commands still work as DefaultNodeHome is passed to the command executor
Part of #33 Follows PR #34 - With earlier workaround in root cmd (not passing `DefaultNodeHome` to depinject), it created a `config/client.toml` wherever the laconicd CLI was being run - Unset `clientCtx.HomeDir` and `clientCtx.KeyringDir` while providing client context to depinject instead to prevent this and still handle the `--home` flag precedence issue - When using default home directory, all commands still work as `DefaultNodeHome` is passed to the [command executor](https://git.vdb.to/cerc-io/laconic2d/src/branch/main/cmd/laconicd/main.go#L18)
prathamesh added 1 commit 2024-07-15 11:36:35 +00:00
Unset home and keyring dir from depinject client config
Build / build (pull_request) Successful in 1m50s
Details
Lint / Run golangci-lint (pull_request) Successful in 4m22s
Details
E2E Tests / test-e2e (pull_request) Successful in 2m46s
Details
Integration Tests / test-integration (pull_request) Successful in 1m45s
Details
SDK Tests / sdk_tests_auctions (pull_request) Successful in 12m11s
Details
SDK Tests / sdk_tests_nameservice_expiry (pull_request) Successful in 6m47s
Details
SDK Tests / sdk_tests (pull_request) Successful in 7m46s
Details
Unit Tests / test-unit (pull_request) Successful in 1m50s
Details
fd395902d9
prathamesh marked the pull request as ready for review 2024-07-15 12:27:34 +00:00
nabarun merged commit 4c0cb6c2c4 into main 2024-07-16 03:50:09 +00:00
nabarun deleted branch pm-handle-config 2024-07-16 03:50:10 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/laconicd#35