cerc-io/laconicd
18
0
Fork 1
Code Issues 21 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Fix progressively increasing gas usage #146

Merged
ashwin merged 4 commits from deep-stack/laconicd:pm-registry-hot-fix into main 2024-04-03 12:14:50 +00:00
Conversation 0 Commits 4 Files Changed 10 +138 -19
prathamesh commented 2024-04-03 06:37:28 +00:00
Member
Copy Link

Part of https://www.notion.so/Set-constant-gas-price-in-laconicd-00b470964f0e4020b06153f0f2c9bcfb

  • Use custom KV store gas config (0 gas for KV store ops) for laconic module (auction, bond, registry) txs
  • Log gas consumed for laconic module txs
  • Handle lint errors
    • Latest version of golangci-lint gets used in the linter CI
    • After the recent release (v1.57.2), it had started throwing some new lint errors (see failing run)
    • Disable dupl rule as it was throwing false positives
Part of https://www.notion.so/Set-constant-gas-price-in-laconicd-00b470964f0e4020b06153f0f2c9bcfb - Use custom KV store gas config (0 gas for KV store ops) for laconic module (auction, bond, registry) txs - Log gas consumed for laconic module txs - Handle lint errors - Latest version of `golangci-lint` gets used in the linter CI - After the recent release ([v1.57.2](https://github.com/golangci/golangci-lint/releases/tag/v1.57.2)), it had started throwing some new lint errors (see [failing run](https://git.vdb.to/cerc-io/laconicd/actions/runs/628/jobs/0)) - Disable `dupl` rule as it was throwing [false positives](https://stackoverflow.com/questions/71611375/how-to-avoid-go-lint-duplication-for-same-pattern-with-different-function)
prathamesh added 2 commits 2024-04-03 06:37:30 +00:00
Use custom KV store gas config for all laconic txs
Some checks failed
Deploy Contract / deploy (pull_request) Successful in 1m25s
Details
Build / build (pull_request) Successful in 2m25s
Details
Tests / test-rpc (pull_request) Successful in 5m47s
Details
Tests / test-importer (pull_request) Successful in 16m25s
Details
Tests / test-unit (pull_request) Successful in 6m43s
Details
Tests / sdk_tests (pull_request) Successful in 9m36s
Details
Lint / Run golangci-lint (pull_request) Failing after 4m21s
Details
Lint / Run flake8 on python integration tests (pull_request) Successful in 1m43s
Details
ea30697b50
prathamesh changed title from [WIP] Handle increasing gas for successive write txs in laconic modules to [WIP] Handle increasing gas for consecutive write txs in laconic modules 2024-04-03 06:40:00 +00:00
prathamesh changed title from [WIP] Handle increasing gas for consecutive write txs in laconic modules to [WIP] Fix progressively increasing gas usage 2024-04-03 06:46:12 +00:00
prathamesh added 2 commits 2024-04-03 09:10:14 +00:00
Handle lint errors
All checks were successful
Deploy Contract / deploy (pull_request) Successful in 1m13s
Details
Lint / Run flake8 on python integration tests (pull_request) Successful in 2m3s
Details
Build / build (pull_request) Successful in 2m49s
Details
Lint / Run golangci-lint (pull_request) Successful in 5m8s
Details
Tests / test-rpc (pull_request) Successful in 5m38s
Details
Tests / sdk_tests (pull_request) Successful in 10m14s
Details
Tests / test-importer (pull_request) Successful in 17m5s
Details
Tests / test-unit (pull_request) Successful in 6m24s
Details
21675b4574
prathamesh changed title from [WIP] Fix progressively increasing gas usage to Fix progressively increasing gas usage 2024-04-03 12:01:30 +00:00
ashwin merged commit 322d6f188b into main 2024-04-03 12:14:50 +00:00
ashwin deleted branch pm-registry-hot-fix 2024-04-03 12:14:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
C:CLI

   
C:Crypto

   
C:Encoding

   
C:Proto

   
C:Types

   
dependencies

Pull requests that update a dependency file

  
docker

Pull requests that update Docker code

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
go

Pull requests that update Go code

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
high priority

   
in progress

currently working on

  
invalid

This doesn't seem right

  
javascript

Pull requests that update Javascript code

  
low priority

   
medium priority

   
question

Further information is requested

  
Status: Stale

   
Type: ADR

   
Type: Build

   
Type: CI

   
Type: Docs

   
Type: Tests

   
urgent

Top priority issue

  
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
C:CLI
C:Crypto
C:Encoding
C:Proto
C:Types
dependencies
docker
documentation
duplicate
enhancement
go
good first issue
help wanted
high priority
in progress
invalid
javascript
low priority
medium priority
question
Status: Stale
Type: ADR
Type: Build
Type: CI
Type: Docs
Type: Tests
urgent
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/laconicd#146
No description provided.
Delete Branch "deep-stack/laconicd:pm-registry-hot-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?