queryRecords should return [] when no records of the type exist, not an error #118

New Issue

telackey · 2023-11-22T20:06:58Z

telackey commented

2023-11-22 20:06:58 +00:00

When queryRecords is executed for a type which has zero records in the DB, it returns an error:

[
  {
    message: `rpc error: code = Unknown desc = store doesn't have key: "\\atypeApplicationRecord"`,
    path: [ 'queryRecords' ]
  }
]

This happens even for valid types. As soon as any record of the type is added, the error goes away, even if no entries match the rest of the query criteria.

When queryRecords is executed for a type which has zero records in the DB, it returns an error: ``` [ { message: `rpc error: code = Unknown desc = store doesn't have key: "\\atypeApplicationRecord"`, path: [ 'queryRecords' ] } ] ``` This happens even for valid types. As soon as any record of the type is added, the error goes away, even if no entries match the rest of the query criteria.

telackey commented

2023-11-22 20:38:48 +00:00

Same thing for names, which will probably be more common:

[
  {
    message: `rpc error: code = Unknown desc = store doesn't have key: "\\anamemy-app-record"`,
    path: [ 'queryRecords' ]
  }
]

Same thing for names, which will probably be more common: ``` [ { message: `rpc error: code = Unknown desc = store doesn't have key: "\\anamemy-app-record"`, path: [ 'queryRecords' ] } ] ```

roysc commented

2023-11-29 04:34:11 +00:00

FWIW this should be fixed on #111: d82c676777

FWIW this should be fixed on https://git.vdb.to/cerc-io/laconicd/pulls/111: https://git.vdb.to/cerc-io/laconicd/commit/d82c6767775b91b973bea3baeeaa1424954a48d0

telackey commented

2023-11-29 17:34:56 +00:00

Excellent. Also fixed by #121, which was merged yesterday.

Excellent. Also fixed by https://git.vdb.to/cerc-io/laconicd/pulls/121, which was merged yesterday.

telackey closed this issue

2023-11-29 17:34:56 +00:00

Sign in to join this conversation.