From bb140939dcd6b8708101130d7e2194dc7ff6ba4b Mon Sep 17 00:00:00 2001 From: Aleksandr Bezobchuk Date: Mon, 9 Jul 2018 15:47:49 -0400 Subject: [PATCH 1/2] Add Github PR template --- .github/PULL_REQUEST_TEMPLATE.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..1fa54ff8 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,12 @@ + + +* [ ] Updated all relevant documentation in docs +* [ ] Updated all code comments where relevant +* [ ] Wrote tests +* [ ] Updated CHANGELOG.md +* [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr)) +* [ ] Added appropriate labels to PR (ex. wip, ready-for-review, docs) From 1960b73752efd33ba2eef5fd8aea791d740a6e95 Mon Sep 17 00:00:00 2001 From: Aleksandr Bezobchuk Date: Mon, 9 Jul 2018 16:43:59 -0400 Subject: [PATCH 2/2] Remove CHANGELOG requirement from PR template --- .github/PULL_REQUEST_TEMPLATE.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1fa54ff8..ee75e68f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -7,6 +7,5 @@ v If a checkbox is n/a - please still include it but + a little note why * [ ] Updated all relevant documentation in docs * [ ] Updated all code comments where relevant * [ ] Wrote tests -* [ ] Updated CHANGELOG.md * [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr)) * [ ] Added appropriate labels to PR (ex. wip, ready-for-review, docs)