actions: fix test-importer workflow (#410)

* actions: fix test-importer workflow

* update gitignore

.github/workflows/test.yml

@@ -193,20 +193,20 @@ jobs:
           file: ./coverage.txt
           fail_ci_if_error: true
         if: "env.GIT_DIFF != ''"
-  # TODO: remove tmp dir to fix this
+
-  # test-importer:
+  test-importer:
-  #   runs-on: ubuntu-latest
+    runs-on: ubuntu-latest
-  #   timeout-minutes: 10
+    timeout-minutes: 10
-  #   steps:
+    steps:
-  #     - uses: actions/checkout@v2
+      - uses: actions/checkout@v2
-  #     - uses: technote-space/get-diff-action@v1
+      - uses: technote-space/get-diff-action@v1
-  #       id: git_diff
+        id: git_diff
-  #       with:
+        with:
-  #         SUFFIX_FILTER: |
+          SUFFIX_FILTER: |
-  #           .go
+            .go
-  #           .mod
+            .mod
-  #           .sum
+            .sum
-  #     - name: importer-test
+      - name: test-importer
-  #       run: |
+        run: |
-  #         make test-import
+          make test-import
-  #       if: "env.GIT_DIFF != ''"
+        if: "env.GIT_DIFF != ''"

.gitignore

@@ -33,6 +33,7 @@ golangci-lint
 coverage.txt
 *.out
 sim_log_file
+importer/tmp
 
 # Vagrant
 .vagrant/

Makefile

@@ -150,6 +150,7 @@ test-race:
 test-import:
 	@go test ./importer -v --vet=off --run=TestImportBlocks --datadir tmp \
 	--blockchain blockchain --timeout=10m
+	rm -rf importer/tmp
 
 test-rpc:
 	./scripts/integration-test-all.sh -q 1 -z 1 -s 2

importer/importer_test.go

@@ -207,7 +207,10 @@ func TestImportBlocks(t *testing.T) {
 	blockchainInput, err := os.Open(flagBlockchain)
 	require.Nil(t, err)
 
-	defer require.NoError(t, blockchainInput.Close())
+	defer func() {
+		err := blockchainInput.Close()
+		require.NoError(t, err)
+	}()
 
 	// ethereum mainnet config
 	chainContext := core.NewChainContext()