cerc-io/laconicd
17
0
Fork 2
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

Fixes gas limit for simulated transaction (#130)

Browse Source 
* Fixes call gas limit for stdTxs

* reword comment
This commit is contained in:
Austin Abell 2019-10-29 11:52:26 -04:00 committed by GitHub
parent 2b4d2bea82
commit 51ff5d48a9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 20 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/ante.go
View File

@ -257,7 +257,7 @@ func ethAnteHandler(
// Set gas meter after ante handler to ignore gaskv costs // Set gas meter after ante handler to ignore gaskv costs
newCtx = auth.SetGasMeter(sim, ctx, ethTxMsg.Data.GasLimit) newCtx = auth.SetGasMeter(sim, ctx, ethTxMsg.Data.GasLimit)
gas, _ := ethcore.IntrinsicGas(ethTxMsg.Data.Payload, ethTxMsg.To() == nil, false) gas, _ := ethcore.IntrinsicGas(ethTxMsg.Data.Payload, ethTxMsg.To() == nil, true)
newCtx.GasMeter().ConsumeGas(gas, "eth intrinsic gas") newCtx.GasMeter().ConsumeGas(gas, "eth intrinsic gas")
return newCtx, sdk.Result{}, false return newCtx, sdk.Result{}, false
@ -313,7 +313,7 @@ func validateSignature(ctx sdk.Context, ethTxMsg *evmtypes.EthereumTxMsg) (sdk.A
// constant value of 21000 plus any cost inccured by additional bytes of data // constant value of 21000 plus any cost inccured by additional bytes of data
// supplied with the transaction. // supplied with the transaction.
func validateIntrinsicGas(ethTxMsg *evmtypes.EthereumTxMsg) sdk.Result { func validateIntrinsicGas(ethTxMsg *evmtypes.EthereumTxMsg) sdk.Result {
gas, err := ethcore.IntrinsicGas(ethTxMsg.Data.Payload, ethTxMsg.To() == nil, false) gas, err := ethcore.IntrinsicGas(ethTxMsg.Data.Payload, ethTxMsg.To() == nil, true)
if err != nil { if err != nil {
return sdk.ErrInternal(fmt.Sprintf("failed to compute intrinsic gas cost: %s", err)).Result() return sdk.ErrInternal(fmt.Sprintf("failed to compute intrinsic gas cost: %s", err)).Result()
} }

4
x/evm/handler.go
View File

@ -73,7 +73,7 @@ func handleETHTxMsg(ctx sdk.Context, keeper Keeper, msg types.EthereumTxMsg) sdk
keeper.csdb.Prepare(ethHash, common.Hash{}, keeper.txCount.get()) keeper.csdb.Prepare(ethHash, common.Hash{}, keeper.txCount.get())
keeper.txCount.increment() keeper.txCount.increment()
res, bloom := st.TransitionCSDB(ctx) bloom, res := st.TransitionCSDB(ctx)
keeper.bloom.Or(keeper.bloom, bloom) keeper.bloom.Or(keeper.bloom, bloom)
return res return res
} }
@ -110,6 +110,6 @@ func handleEmintMsg(ctx sdk.Context, keeper Keeper, msg types.EmintMsg) sdk.Resu
keeper.csdb.Prepare(common.Hash{}, common.Hash{}, keeper.txCount.get()) // Cannot provide tx hash keeper.csdb.Prepare(common.Hash{}, common.Hash{}, keeper.txCount.get()) // Cannot provide tx hash
keeper.txCount.increment() keeper.txCount.increment()
res, _ := st.TransitionCSDB(ctx) _, res := st.TransitionCSDB(ctx)
return res return res
} }

21
x/evm/types/state_transition.go
View File

@ -29,15 +29,26 @@ type StateTransition struct {
} }
// TransitionCSDB performs an evm state transition from a transaction // TransitionCSDB performs an evm state transition from a transaction
func (st StateTransition) TransitionCSDB(ctx sdk.Context) (sdk.Result, *big.Int) { func (st StateTransition) TransitionCSDB(ctx sdk.Context) (*big.Int, sdk.Result) {
contractCreation := st.Recipient == nil contractCreation := st.Recipient == nil
if res := st.checkNonce(); !res.IsOK() { if res := st.checkNonce(); !res.IsOK() {
return res, nil return nil, res
}
cost, err := core.IntrinsicGas(st.Payload, st.Recipient == nil, true)
if err != nil {
return nil, sdk.ErrOutOfGas("invalid intrinsic gas for transaction").Result()
} }
// This gas limit the the transaction gas limit with intrinsic gas subtracted // This gas limit the the transaction gas limit with intrinsic gas subtracted
gasLimit := ctx.GasMeter().Limit() gasLimit := st.GasLimit - ctx.GasMeter().GasConsumed()
if st.Simulate {
// gasLimit is set here because stdTxs incur gaskv charges in the ante handler, but for eth_call
// the cost needs to be the same as an Ethereum transaction sent through the web3 API
gasLimit = st.GasLimit - cost
}
// Create context for evm // Create context for evm
context := vm.Context{ context := vm.Context{
@ -92,7 +103,7 @@ func (st StateTransition) TransitionCSDB(ctx sdk.Context) (sdk.Result, *big.Int)
if vmerr != nil { if vmerr != nil {
res := emint.ErrVMExecution(vmerr.Error()).Result() res := emint.ErrVMExecution(vmerr.Error()).Result()
res.Data = returnData res.Data = returnData
return res, nil return nil, res
} }
// TODO: Refund unused gas here, if intended in future // TODO: Refund unused gas here, if intended in future
@ -103,7 +114,7 @@ func (st StateTransition) TransitionCSDB(ctx sdk.Context) (sdk.Result, *big.Int)
// Out of gas check does not need to be done here since it is done within the EVM execution // Out of gas check does not need to be done here since it is done within the EVM execution
ctx.GasMeter().ConsumeGas(gasLimit-leftOverGas, "EVM execution consumption") ctx.GasMeter().ConsumeGas(gasLimit-leftOverGas, "EVM execution consumption")
return sdk.Result{Data: returnData, GasUsed: st.GasLimit - leftOverGas}, bloomInt return bloomInt, sdk.Result{Data: returnData, GasUsed: st.GasLimit - leftOverGas}
} }
func (st *StateTransition) checkNonce() sdk.Result { func (st *StateTransition) checkNonce() sdk.Result {