fix: server should always use local rpc client (#988)

Closes: #987
Solution:
- use local rpc clint if json-rpc is enabled.

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
This commit is contained in:
yihuang 2022-03-15 18:28:14 +08:00 committed by GitHub
parent 6b88b26a40
commit 49afc0f90d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions

View File

@ -55,6 +55,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
### Improvements ### Improvements
- (rpc) [tharsis#979](https://github.com/tharsis/ethermint/pull/979) Add configurable timeouts to http server - (rpc) [tharsis#979](https://github.com/tharsis/ethermint/pull/979) Add configurable timeouts to http server
- (rpc) [tharsis#988](https://github.com/tharsis/ethermint/pull/988) json-rpc server always use local rpc client
## [v0.10.1] - 2022-03-04 ## [v0.10.1] - 2022-03-04

View File

@ -318,9 +318,9 @@ func startInProcess(ctx *server.Context, clientCtx client.Context, appCreator ty
} }
// Add the tx service to the gRPC router. We only need to register this // Add the tx service to the gRPC router. We only need to register this
// service if API or gRPC is enabled, and avoid doing so in the general // service if API or gRPC or JSONRPC is enabled, and avoid doing so in the general
// case, because it spawns a new local tendermint RPC client. // case, because it spawns a new local tendermint RPC client.
if config.API.Enable || config.GRPC.Enable { if config.API.Enable || config.GRPC.Enable || config.JSONRPC.Enable {
clientCtx = clientCtx.WithClient(local.New(tmNode)) clientCtx = clientCtx.WithClient(local.New(tmNode))
app.RegisterTxService(clientCtx) app.RegisterTxService(clientCtx)