cerc-io/laconicd
18
0
Fork 2
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 11 Wiki Activity

rpc: remove error on personal_unlockAccount (#128)

Browse Source 
* rpc: unlock key by default

* return false

* add ref to issue
This commit is contained in:
Federico Kunze 2021-06-15 03:18:58 -04:00 committed by GitHub
parent 5af5dd9956
commit 3a74d2402b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ethereum/rpc/personal.go
View File

@ -94,9 +94,10 @@ func (api *PrivateAccountAPI) ListAccounts() ([]common.Address, error) {
// LockAccount will lock the account associated with the given address when it's unlocked. // LockAccount will lock the account associated with the given address when it's unlocked.
// It removes the key corresponding to the given address from the API's local keys. // It removes the key corresponding to the given address from the API's local keys.
func (api *PrivateAccountAPI) LockAccount(address common.Address) bool { func (api *PrivateAccountAPI) LockAccount(address common.Address) bool { // nolint: interfacer
api.logger.Debugln("personal_lockAccount", "address", address.String()) api.logger.Debugln("personal_lockAccount", "address", address.String())
api.logger.Info("personal_lockAccount not supported") api.logger.Info("personal_lockAccount not supported")
// TODO: Not supported. See underlying issue https://github.com/99designs/keyring/issues/85
return false return false
} }
@ -122,11 +123,10 @@ func (api *PrivateAccountAPI) NewAccount(password string) (common.Address, error
// UnlockAccount will unlock the account associated with the given address with // UnlockAccount will unlock the account associated with the given address with
// the given password for duration seconds. If duration is nil it will use a // the given password for duration seconds. If duration is nil it will use a
// default of 300 seconds. It returns an indication if the account was unlocked. // default of 300 seconds. It returns an indication if the account was unlocked.
// It exports the private key corresponding to the given address from the keyring and stores it in the API's local keys. func (api *PrivateAccountAPI) UnlockAccount(_ context.Context, addr common.Address, _ string, _ *uint64) (bool, error) { // nolint: interfacer
func (api *PrivateAccountAPI) UnlockAccount(_ context.Context, addr common.Address, password string, _ *uint64) (bool, error) { // nolint: interfacer
api.logger.Debugln("personal_unlockAccount", "address", addr.String()) api.logger.Debugln("personal_unlockAccount", "address", addr.String())
api.logger.Info("personal_unlockAccount not supported") // TODO: Not supported. See underlying issue https://github.com/99designs/keyring/issues/85
return false, fmt.Errorf("not supported") return false, nil
} }
// SendTransaction will create a transaction from the given arguments and // SendTransaction will create a transaction from the given arguments and