From 38c228cc1a2b238270a46a2ca3f452e7912a9fa8 Mon Sep 17 00:00:00 2001 From: Aleksandr Bezobchuk Date: Wed, 22 Aug 2018 09:53:27 -0400 Subject: [PATCH] Address PR reviews in regards to transaction sigs --- docs/spec/transactions/README.md | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/docs/spec/transactions/README.md b/docs/spec/transactions/README.md index 924bc787..2121cee4 100644 --- a/docs/spec/transactions/README.md +++ b/docs/spec/transactions/README.md @@ -48,19 +48,19 @@ Cosmos SDK `sdk.Tx` interface. ## Signatures Ethermint supports [EIP-155](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-155.md) -signatures. However, just as in Cosmos, Ethermint will support multiple signers. -A client is expected to sign the `Transaction` just as in Ethereum, however, the -`EmbeddedTx` contains a canonical signature structure that itself contains the -signature and other information such as an account's sequence number. The sequence -number is expected to increment every time a message is signed by a given account. -This prevents "replay attacks", where the same message could be executed over and -over again. +signatures. A `Transaction` is expected to have a single signature for Ethereum +routed transactions. However, just as in Cosmos, Ethermint will support multiple +signers for `EmbeddedTx` Cosmos routed transactions. Signatures over the +`Transaction` type are identical to Ethereum. However, the `EmbeddedTx` contains +a canonical signature structure that contains the signature itself and other +information such as an account's sequence number. The sequence number is expected +to increment every time a message is signed by a given account. This, in addition +to the chain ID, prevents "replay attacks", where the same message could be +executed over and over again. -An `EmbeddedTx` list of signatures must much the unique list of addresses returned by -each message's `GetSigners` call. In addition, the address of first signer of the -`EmbeddedTx` is responsible for paying the fees and must also match the address of -the signer of the embedding `Transaction`. As such, there will be one duplicate -signature. +An `EmbeddedTx` list of signatures must much the unique list of addresses returned +by each message's `GetSigners` call. In addition, the address of first signer of +the `EmbeddedTx` is responsible for paying the fees. ## Gas & Fees