d3333418c5
* bug(feemarket): set lower bound of base fee to min gas price param) * fix * bug(feemarket): flag necessary improvement to integration tests, as the baseFee changes for every test * bug(feemarket): add unit tests for CalculateBaseFee * bug(feemarket): move integration test setup out of Describe block * wip fix tests * bug(feemarket): fix integration tests * bug(feemarket): wip improve specs * bug(feemarket): add spec concepts * bug(feemarket): remove todo * bug(feemarket): remove changes used for debugging in params * bug(feemarket): remove todo in integration test * add changelog * address PR comments Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
93 lines
3.2 KiB
Go
93 lines
3.2 KiB
Go
package keeper
|
|
|
|
import (
|
|
"math/big"
|
|
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
|
|
"github.com/ethereum/go-ethereum/common"
|
|
"github.com/ethereum/go-ethereum/common/math"
|
|
)
|
|
|
|
// CalculateBaseFee calculates the base fee for the current block. This is only calculated once per
|
|
// block during BeginBlock. If the NoBaseFee parameter is enabled or below activation height, this function returns nil.
|
|
// NOTE: This code is inspired from the go-ethereum EIP1559 implementation and adapted to Cosmos SDK-based
|
|
// chains. For the canonical code refer to: https://github.com/ethereum/go-ethereum/blob/master/consensus/misc/eip1559.go
|
|
func (k Keeper) CalculateBaseFee(ctx sdk.Context) *big.Int {
|
|
params := k.GetParams(ctx)
|
|
|
|
// Ignore the calculation if not enabled
|
|
if !params.IsBaseFeeEnabled(ctx.BlockHeight()) {
|
|
return nil
|
|
}
|
|
|
|
consParams := ctx.ConsensusParams()
|
|
|
|
// If the current block is the first EIP-1559 block, return the base fee
|
|
// defined in the parameters (DefaultBaseFee if it hasn't been changed by
|
|
// governance).
|
|
if ctx.BlockHeight() == params.EnableHeight {
|
|
return params.BaseFee.BigInt()
|
|
}
|
|
|
|
// get the block gas used and the base fee values for the parent block.
|
|
// NOTE: this is not the parent's base fee but the current block's base fee,
|
|
// as it is retrieved from the transient store, which is committed to the
|
|
// persistent KVStore after EndBlock (ABCI Commit).
|
|
parentBaseFee := params.BaseFee.BigInt()
|
|
if parentBaseFee == nil {
|
|
return nil
|
|
}
|
|
|
|
parentGasUsed := k.GetBlockGasWanted(ctx)
|
|
|
|
gasLimit := new(big.Int).SetUint64(math.MaxUint64)
|
|
|
|
// NOTE: a MaxGas equal to -1 means that block gas is unlimited
|
|
if consParams != nil && consParams.Block.MaxGas > -1 {
|
|
gasLimit = big.NewInt(consParams.Block.MaxGas)
|
|
}
|
|
|
|
// CONTRACT: ElasticityMultiplier cannot be 0 as it's checked in the params
|
|
// validation
|
|
parentGasTargetBig := new(big.Int).Div(gasLimit, new(big.Int).SetUint64(uint64(params.ElasticityMultiplier)))
|
|
if !parentGasTargetBig.IsUint64() {
|
|
return nil
|
|
}
|
|
|
|
parentGasTarget := parentGasTargetBig.Uint64()
|
|
baseFeeChangeDenominator := new(big.Int).SetUint64(uint64(params.BaseFeeChangeDenominator))
|
|
|
|
// If the parent gasUsed is the same as the target, the baseFee remains
|
|
// unchanged.
|
|
if parentGasUsed == parentGasTarget {
|
|
return new(big.Int).Set(parentBaseFee)
|
|
}
|
|
|
|
if parentGasUsed > parentGasTarget {
|
|
// If the parent block used more gas than its target, the baseFee should
|
|
// increase.
|
|
gasUsedDelta := new(big.Int).SetUint64(parentGasUsed - parentGasTarget)
|
|
x := new(big.Int).Mul(parentBaseFee, gasUsedDelta)
|
|
y := x.Div(x, parentGasTargetBig)
|
|
baseFeeDelta := math.BigMax(
|
|
x.Div(y, baseFeeChangeDenominator),
|
|
common.Big1,
|
|
)
|
|
|
|
return x.Add(parentBaseFee, baseFeeDelta)
|
|
}
|
|
|
|
// Otherwise if the parent block used less gas than its target, the baseFee
|
|
// should decrease.
|
|
gasUsedDelta := new(big.Int).SetUint64(parentGasTarget - parentGasUsed)
|
|
x := new(big.Int).Mul(parentBaseFee, gasUsedDelta)
|
|
y := x.Div(x, parentGasTargetBig)
|
|
baseFeeDelta := x.Div(y, baseFeeChangeDenominator)
|
|
|
|
// Set global min gas price as lower bound of the base fee, transactions below
|
|
// the min gas price don't even reach the mempool.
|
|
minGasPrice := params.MinGasPrice.TruncateInt().BigInt()
|
|
return math.BigMax(x.Sub(parentBaseFee, baseFeeDelta), minGasPrice)
|
|
}
|