Changes to run laconic-console app with laconicd #75

2023-01-11T05:52:10Z

nikugogoi commented

2023-01-11 05:52:10 +00:00

(Migrated from github.com)

Part of https://github.com/cerc-io/laconic-console/issues/3

Description

Add CORS middleware for GQL requests
Load query from URL in GQL playground
Load record names in getRecordsByIds GQL query

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Part of https://github.com/cerc-io/laconic-console/issues/3 ## Description - Add CORS middleware for GQL requests - Load query from URL in GQL playground - Load record names in `getRecordsByIds` GQL query  ______ For contributor use: - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer ______ For admin use: - [ ] Added appropriate labels to PR (ex. `WIP`, `R4R`, `docs`, etc) - [ ] Reviewers assigned - [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))

github-code-scanning[bot] (Migrated from github.com) reviewed 2023-01-11 05:53:20 +00:00

gql/graphiql.go

github-code-scanning[bot] (Migrated from github.com) commented

2023-01-11 05:53:20 +00:00

Insecure WebSocket Detected. WebSocket Secure (wss) should be used for all WebSocket connections.

Show more details

## Insecure WebSocket Detected. WebSocket Secure (wss) should be used for all WebSocket connections. Insecure WebSocket Detected. WebSocket Secure (wss) should be used for all WebSocket connections. [Show more details](https://github.com/cerc-io/laconicd/security/code-scanning/561)

github-code-scanning[bot] (Migrated from github.com) commented

2023-01-11 05:53:20 +00:00

Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'.

Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'.

Show more details

## Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'. Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'. [Show more details](https://github.com/cerc-io/laconicd/security/code-scanning/559)

gql/server.go

github-code-scanning[bot] (Migrated from github.com) commented

2023-01-11 05:53:20 +00:00

Found an HTTP server without TLS. Use 'http.ListenAndServeTLS' instead. See https://golang.org/pkg/net/http/#ListenAndServeTLS for more information.

Show more details

## Found an HTTP server without TLS. Use 'http.ListenAndServeTLS' instead. See https://golang.org/pkg/net/http/#ListenAndServeTLS for more information. Found an HTTP server without TLS. Use 'http.ListenAndServeTLS' instead. See https://golang.org/pkg/net/http/#ListenAndServeTLS for more information. [Show more details](https://github.com/cerc-io/laconicd/security/code-scanning/560)

codecov-commenter commented

2023-01-11 06:05:07 +00:00

(Migrated from github.com)

Codecov Report

Merging #75 (259b1f8) into main (cb104e0) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   66.57%   66.57%           
=======================================
  Files         145      145           
  Lines       15953    15953           
=======================================
  Hits        10620    10620           
  Misses       4859     4859           
  Partials      474      474

Impacted Files	Coverage Δ
x/registry/keeper/keeper.go	`48.92% <100.00%> (ø)`

# [Codecov](https://codecov.io/gh/cerc-io/laconicd/pull/75?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Report > Merging [#75](https://codecov.io/gh/cerc-io/laconicd/pull/75?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (259b1f8) into [main](https://codecov.io/gh/cerc-io/laconicd/commit/cb104e0b108b91d0a26f23ed48e71665b250e55a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (cb104e0) will **not change** coverage. > The diff coverage is `100.00%`. <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://codecov.io/gh/cerc-io/laconicd/pull/75/graphs/tree.svg?width=650&height=150&src=pr&token=5tWmn7LxfO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)](https://codecov.io/gh/cerc-io/laconicd/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #75 +/- ## ======================================= Coverage 66.57% 66.57% ======================================= Files 145 145 Lines 15953 15953 ======================================= Hits 10620 10620 Misses 4859 4859 Partials 474 474 ``` | [Impacted Files](https://codecov.io/gh/cerc-io/laconicd/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [x/registry/keeper/keeper.go](https://codecov.io/gh/cerc-io/laconicd/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-eC9yZWdpc3RyeS9rZWVwZXIva2VlcGVyLmdv) | `48.92% <100.00%> (ø)` | | </details>

Sign in to join this conversation.

No reviewers